Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycle consistency plots are written synchronously (does not work on cluster) #631

Open
akshay-krishnan opened this issue Apr 28, 2023 · 1 comment
Open

Cycle consistency plots are written synchronously (does not work on cluster) #631

akshay-krishnan opened this issue Apr 28, 2023 · 1 comment

Comments

@akshay-krishnan
Copy link
Collaborator

Cycle consistency filtering writes plots in the run() method, without any dask.annotate() call to specify which machine to write these plots on. This fails on the cluster because there is no guarantee that the directory to write the plots to will exist on the machine running cycle consistency. Even if there is, the plots will not be obtained on the machine from which gtsfm is run.

gtsfm/gtsfm/view_graph_estimator/cycle_consistent_rotation_estimator.py

Line 137 in 4a9dc6a

self.__save_plots(

@akshay-krishnan
Copy link
Collaborator Author

cc @johnwlambert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akshay-krishnan