Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_libname.py logic #271

Open
sdarwin opened this issue Feb 28, 2025 · 3 comments · May be fixed by #273
Open

get_libname.py logic #271

sdarwin opened this issue Feb 28, 2025 · 3 comments · May be fixed by #273

Comments

@sdarwin
Copy link
Collaborator

sdarwin commented Feb 28, 2025

This is just an idea. Boost Tribool has an unusual meta/libraries.json that can break CI
https://github.com/boostorg/logic/blob/develop/meta/libraries.json

Solution:
Modify get_libname.py to deal with this exception. Add a custom case in get_libname.py.

That would 'fix' the lcov report.
And remove the need to customize SELF in all other CI jobs, which is happening currently for tribool.

@Flamefire
Copy link
Collaborator

And remove the need to customize SELF in all other CI jobs, which is happening currently for tribool.

What exactly do you mean by that?

Modify get_libname.py to deal with this exception.

Yeah I guess something like this should be easy and extensible if required

name_fixups = { 'logic/tribool': 'logic' }
key = lib_data['key']
print(name_fixups.get(key, key))

@sdarwin
Copy link
Collaborator Author

sdarwin commented Feb 28, 2025

What exactly do you mean by that?

  • tribool's own CI jobs, in that repository, are forced to set a customized value, because otherwise they would fail.
  • the new lcov report also is not able to determine SELF for tribool

@Flamefire Flamefire linked a pull request Feb 28, 2025 that will close this issue
@Flamefire
Copy link
Collaborator

I see. I wasn't sure about the "all other CI jobs", but it was only the tribool CI jobs, so expected.

Added a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants