Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential race condition caching the value of PortName when subscribing to Device node #89

Open
glopesdev opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@glopesdev
Copy link
Member

@aspaNeuro reported a potential race condition when concurrently initializing multiple Device nodes inside a loop where PortName may be cached too late, leading to name clashes during initialization.

If confirmed, this could potentially be traced back to the assignment below which is executed inside an async method. Because we do not control which parts of async methods run synchronously vs not, we may have to move this caching earlier to ensure it is made synchronous with either subscription or observable construction.

var portName = PortName;

@glopesdev glopesdev added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant