You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The requirement to expose this WhoAmI was somewhat made mute by the device-specific APIs that implement the WhoAmI check on connection since these know what ID to expect to find.
There is however a scenario where having the WhoAmI exposed in the core class still makes some sense. Consider a user who has some sort of specification that maps ComPort -> WhoAmI.
We can then use ComPort to instantiate Observables that connect to different devices on different ports. This is already possible and an efficient way to connect to harp devices dynamically. The caveat here is that the WhoAmI information cannot currently be used to make check if the device we connected to is the expected device. If this property is exposed, we can leverage the already existing constructor to have this behavior for free.
The proposal is thus to expose the WhoAmI property in the current operator as a Nullable<int> that by default will be null and ensure backward compatibility. If a value is defined, the aforementioned constructor will be used and the WhoAmI code will be asserted.
The text was updated successfully, but these errors were encountered:
The
Device
constructor overload that takes aWhoAmI
is not exposed in the Bonsai operator.harp/Bonsai.Harp/Device.cs
Line 38 in affa52f
The requirement to expose this WhoAmI was somewhat made mute by the device-specific APIs that implement the WhoAmI check on connection since these know what ID to expect to find.
There is however a scenario where having the WhoAmI exposed in the core class still makes some sense. Consider a user who has some sort of specification that maps
ComPort -> WhoAmI
.We can then use
ComPort
to instantiate Observables that connect to different devices on different ports. This is already possible and an efficient way to connect to harp devices dynamically. The caveat here is that the WhoAmI information cannot currently be used to make check if the device we connected to is the expected device. If this property is exposed, we can leverage the already existing constructor to have this behavior for free.The proposal is thus to expose the WhoAmI property in the current operator as a
Nullable<int>
that by default will be null and ensure backward compatibility. If a value is defined, the aforementioned constructor will be used and theWhoAmI
code will be asserted.The text was updated successfully, but these errors were encountered: