-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite on Bolt card with bolt card wallet fails if firstly written by LNBits extension (2 c values) #28
Comments
Thanks for checking. Why do you think the NDEF file may not be fully cleared? And why does LNBits extension + Boltcard NFC Programmer allows to write on that? |
Not sure. Any ideas @robertclarkson ? |
Looking at the screen shot seems to give a clue... There are 2 C parameters in the URL which is very strange there should only be one. And this would explain the weirdness. How 2 C parameters got there... Not sure. |
Looks like a possible string handling issue with missing \0 termination character. Ideally the wipe should remove all previous character data and replace with \0s. |
Yes have just tested with android as well and can confirm this is a bug thanks for the feedback @psychoet |
to recreate the issue: https://github.com/boltcard/bolt-nfc-android-app/blob/master/testing.md
|
I feel sorry for not being helpful on finding the solution, but is there anything I can do to help? |
Thank you for offering. |
Made some on geyser. I was a bit surprised by the amount raised - too small! |
from the Telegram group for similar report "And it is somehow also possible to pay with it some times but it crashes the hub and I get API errors on the working card/wallet until I restart" this indicates separate but related issue in the hub and wallet |
I am the guy from the telegram group. Seems to be the same problem here, but I was able to do one payment after a selfpayment. The payment was only possible after first paying the same wallet with the card that is connected to.
Maybe this helps. I'll try to figure out more stuff next saturday when I have time. |
I got around testing it but didn't really figure out why it writes a second c param with only 0. However, the CMAC Test probably fails because the first c param which would be correct is overwritten bei the second one with only zeroes. boltcard-wallet/screen/boltcard/create.js Line 314 in 4a14961
I have no idea how to build an APK or such thing. So I have to leave it here I guess. |
Do you need support? Try asking on the telegram group
Already reported and discussed in Telegram. No solution was retrieved.
Are you reporting a bug?
Yes. Already made a comment on issue #27 , but this one is more inclusive report.
The cards used in the test were:
- Coincorners
- Lasereyes
The devices used in the test were:
The software used to reproduce this case were:
1. Lasereyes card
Created a bolt card record from LNBits extension, and write it via 'create' QR code/link. Tested successful payments, and wiped it via 'Wipe' QR code/link on both machine (iPhone, Android POS). (also tried to 'erase tag' using NFC tools.)
After that, tried to connect the card using Bolt card wallet app & Bolt card hub, but failed only at "Keys ready to change: no x" and "Test CMAC: decrypt with key failed x". Other writing procedures were successful. The payment did not work.
After wipe the card using bolt card wallet app, I tried again with LNBits extension for card registration, and it worked well.
2. Coincorner card
I realized that I have one new coincorner's bolt card, so tested on iPhone Bolt Card Wallet app with bolt card hub. Writing was successful without any issue, and payment worked well. I am not doing further test with this card since I do not want to lose the only way to utilize my bolt card hub for now.
The text was updated successfully, but these errors were encountered: