Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe issue with extension #68

Closed
niners52 opened this issue Sep 22, 2021 · 1 comment
Closed

Adobe issue with extension #68

niners52 opened this issue Sep 22, 2021 · 1 comment

Comments

@niners52
Copy link

DETAIL: OBSOLETE _ISSCOPEPRIVATE PROPERTY

Description

The following table shows the private content block(s) that have the _isScopePrivate variables configured making the block not cacheable.

PATH

vendor/boldcommerce/magento2-ordercomments/Block/Order/Comment.php

Recommendation

Do not use the _isScopePrivate property in your blocks. This property is obsolete and will not work properly.

Replace _isScopePrivate property by private content instead.

Reference our developer documentation for guidance:

Please submit a Magento Support ticket for assistance or feedback.

Root Cause

The _isPrivateScope variable is making block(s) not cacheable. 

Scenario/Preconditions

Since private content is specific to individual users, it is reasonable to handle this on the client-side (i.e., the web browser) instead of hitting the server for retrieving the same data on each customer request.

Always test in the Staging environment prior to making any changes to the Production environment.

Site Impact

Each request to Magento can trigger additional Ajax requests for non-cacheable blocks causing negative  site performance.


@boldbart
Copy link
Contributor

Duplicate #47

@boldbart boldbart closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants