Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 has broken cFIREsim #73

Open
jamesplease opened this issue Jan 5, 2018 · 1 comment
Open

2018 has broken cFIREsim #73

jamesplease opened this issue Jan 5, 2018 · 1 comment

Comments

@jamesplease
Copy link

Steps to reproduce:

  1. Navigate to http://www.cfiresim.com/
  2. In DevTools, wipe all application data (just to be safe!)
  3. Refresh the page
  4. Click "Run Simulation"
  5. Observe that no Statistics appear
  6. In DevTools, observe the following stack trace TypeError: Cannot read property 'infAdjSpending' of undefined

This error occurs within calcWithdrawalAnalysis. The first line of this function is var currentYear = new Date().getFullYear();

If you put a break point here and adjust the value to be 2017 (rather than 2018), then the simulation will be fixed, and you will see your statistics.

I didn't go through the code to see why this breaks it, but it may have to do with the market data that's available.

This problem may have justified the copy and pasting of market data that was done in recent years, leading to issues such as #68 .

Thanks for reading!

@jamesplease
Copy link
Author

The issue seems to be that the Retirement Year is still populating as 2017 in the form. Changing that to 2018 solves the problemo. This fix also resolves #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant