Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Five PRs in one: Update to Python 3, rely on PATH, rename script, fix a typo, add gerdriesselmann's fix from issue #2 #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Five PRs in one: Update to Python 3, rely on PATH, rename script, fix a typo, add gerdriesselmann's fix from issue #2 #3

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a044d5f
Add fix for when MegaCLI returns N/A instead of a number
hacklschorsch Oct 18, 2021
3da003b
Merge branch 'fix-for-NA-out'
hacklschorsch Oct 18, 2021
ed28147
Name executable more aptly
hacklschorsch Oct 18, 2021
43a5cee
Be more flexible regarding the whereabouts of our python interpreter
hacklschorsch Oct 18, 2021
67e9cad
Waltz 2to3 over that script
hacklschorsch Oct 18, 2021
b845de8
Fix speling
hacklschorsch Oct 18, 2021
9536933
Rely on system PATH to find MegaCli64 utility
hacklschorsch Nov 3, 2021
a7775a0
Remove the extra braces 2to3 added just in case
hacklschorsch Nov 3, 2021
c4c4ecb
Fix `IndexError: list index out of range' while parsing temperature
hacklschorsch Dec 23, 2021
0ebe103
Merge branch 'fix-out-of-range-error'
hacklschorsch Dec 23, 2021
e76300c
Merge branch 'main' of github.com:PrivateStorageio/megacli2prom
hacklschorsch Dec 23, 2021
2872bf3
Fix exception handling: Add sys import for the output to stderr
hacklschorsch Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions megacli.py → megacli2prom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#!/usr/bin/python
#!/usr/bin/env python

import subprocess
import re
import json
import sys

def yesno(state):
states = {
Expand Down Expand Up @@ -32,15 +33,15 @@ def tobytes(inp):
return inp

def main():
info = subprocess.check_output(['/opt/MegaRAID/MegaCli/MegaCli64', '-AdpAllInfo', '-aAll', '-nolog']).decode('utf-8').splitlines()
pdlist = subprocess.check_output(['/opt/MegaRAID/MegaCli/MegaCli64', '-PdList', '-aAll', '-nolog']).decode('utf-8').splitlines()
info = subprocess.check_output(['MegaCli64', '-AdpAllInfo', '-aAll', '-nolog']).decode('utf-8').splitlines()
pdlist = subprocess.check_output(['MegaCli64', '-PdList', '-aAll', '-nolog']).decode('utf-8').splitlines()
out = {}
adapter = None

metrics= [
'out["megacli_controller"]={ "help": "Controler information", "type": "gauge" , "metrics": []}',
'out["megacli_controller"]={ "help": "Controller information", "type": "gauge" , "metrics": []}',
'out["megacli_controller_temperature_celsius"]={ "help": "ROC Temperature", "type": "gauge" , "metrics": []}',
'out["megacli_memory_size_bytes"]={ "help": "Controler memory information", "type": "gauge" , "metrics": []}',
'out["megacli_memory_size_bytes"]={ "help": "Controller memory information", "type": "gauge" , "metrics": []}',
'out["megacli_drives"]={ "help": "Drives information", "type": "gauge" , "metrics": []}',
'out["megacli_memory_errors"]={ "help": "Memory errors", "type": "gauge" , "metrics": []}',
'out["megacli_pd_info"]={ "help": "Physical drive detailed info", "type": "gauge" , "metrics": []}',
Expand Down Expand Up @@ -295,15 +296,22 @@ def main():
for p in pat_pd:
if p['regex'].match(line):
for a in p['action']:
exec(a)
try:
exec(a)
except:
print("Exception parsing metric: " + line + ", regex: " + p['regex'].pattern + ", action: " + a, file=sys.stderr)
pass
continue

# print json.dumps(out, indent=2, sort_keys=True)
for k,v in out.iteritems():
for k,v in out.items():
print("# HELP " + k + " " + v['help'])
print("# TYPE " + k + " " + v['type'])
for m in v['metrics']:
print ( str(k) + '{' + ', '.join([ "{}=\"{}\"".format(str(l),str(m['labels'][l])) for l in sorted(m['labels']) ]) + '} ' + str(m['val']) )
clean = str(m['val'])
if clean.replace('.','',1).isdigit() == False:
clean = '0'
print(( str(k) + '{' + ', '.join([ "{}=\"{}\"".format(str(l),str(m['labels'][l])) for l in sorted(m['labels']) ]) + '} ' + clean ))

if __name__ == "__main__":
main()