Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DNS client optional in GSS-TSIG constructor #58

Open
bodgit opened this issue Nov 1, 2021 · 0 comments
Open

Make DNS client optional in GSS-TSIG constructor #58

bodgit opened this issue Nov 1, 2021 · 0 comments
Assignees
@bodgit
Labels
backwards-incompatible

Comments

@bodgit
Copy link
Owner

bodgit commented Nov 1, 2021

Now there's a variadic parameter on the constructor, I could drop the required first parameter and add a gss.WithDNSClient(client) option function, and make the default a new dns.Client with the transport set to tcp.

This would be a v2 change.
@bodgit bodgit self-assigned this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bodgit bodgit

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bodgit