Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot tries to also handle old closed and merged pull_requests and runs into errors #886

Open
roydenwa opened this issue Oct 28, 2020 · 1 comment

Comments

@roydenwa
Copy link

The bot is used in a large repo with the following simple config:

blockingLabels:
- 'SKIP ALL'

requiredLabels:
- AutoMerge

deleteBranchAfterMerge: true

mergeMethod: squash

The error logs suggest that the bot is also trying to handle old closed and merged pull_requests.
Could this unwanted behavior be due to the fact that the getAssosiatedPullRequests function in index.ts sometimes returns all pull_requests for a certain repo?

@epDHowwD
Copy link

The noticeable issue is that the bot looks a lot into irrelevant old, partially closed, PRs, but less into recent updated PRs. The effect is that PRs being ready to be merged stay unmerged for several hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants