Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minApprovals considers CONTRIBUTOR to be "less than" MEMBER #874

Open
sebastiankirsch opened this issue Oct 14, 2020 · 0 comments
Open

minApprovals considers CONTRIBUTOR to be "less than" MEMBER #874

sebastiankirsch opened this issue Oct 14, 2020 · 0 comments

Comments

@sebastiankirsch
Copy link

Hey there, I'm having trouble configuring probot so it matches our use case.

Here's my configuration:

minApprovals:
  MEMBER: 2

For an example PR, I get 2 approvals from what are MEMBERs according to https://developer.github.com/v4/enum/commentauthorassociation/
Yet, the approvers are reported as CONTRIBUTORs - which is correct for that particular repo.

Unfortunately, it seems probot considers contributors to be "less than" members. I see how that makes sense for public repositories - yet in our case (internal repo of an organization), this is at least unexpected and/or misleading.

I understand that this is a tricky thing to solve, yet I still believe it's a mismatch between what github considers to be "more valueable" and Probot does...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant