Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question regrading minApprovals authorAssociation #833

Open
xli1996 opened this issue Aug 26, 2020 · 1 comment
Open

question regrading minApprovals authorAssociation #833

xli1996 opened this issue Aug 26, 2020 · 1 comment

Comments

@xli1996
Copy link

xli1996 commented Aug 26, 2020

Hi, maybe I do not fully understand the document, in the example in README
https://github.com/bobvanderlinden/probot-auto-merge#minapprovals-required-condition

In the example below when a pull request gets 2 approvals from owners, members or collaborators, the automatic merge will continue.

minApprovals:
  COLLABORATOR: 2

However, when I tried on a private repo, the PR get approved does not get merged due to

    "minimumApprovals": {
      "status": "fail",
      "message": "There are not enough approvals by reviewers"
    },

And I search on graphql find that

        "reviews": {
          "nodes": [
            {
              "authorAssociation": "CONTRIBUTOR",
              "author": {
                "login": "****"
              },
              "submittedAt": "*****",
              "state": "APPROVED"
            }

I wonder does the reviewer's authorAssociation has to match what in minApprovals. Is there anyway to auto merge if there is any approval without authorAssociation? I think it could be done by setting branch protection rules, but I wonder if the pro-bot may capable of it as well.

@bobvanderlinden
Copy link
Owner

CONTRIBUTOR is considered a lower association than COLLABORATOR. You can accept any approvals using NONE: 2. Any approvals is not recommended for public repos as it would allow anyone to merge a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants