Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR was auto-merged before required checks completed #1178

Open
joberstein opened this issue Nov 16, 2022 · 1 comment
Open

PR was auto-merged before required checks completed #1178

joberstein opened this issue Nov 16, 2022 · 1 comment

Comments

@joberstein
Copy link

joberstein commented Nov 16, 2022

I recently started using probot-auto-merge for some of my repos, so I may be missing something.

Dependabot opened a PR to bump up one of my testing libraries. However, the required checks failed because dependabot attempted a major version bump, and the project would not compile.

At this point, I updated the dependabot branch locally and pushed. As soon as I did, my PR was merged automatically, even though the required checks had not completed.

The attached screenshot shows that the build was previously failing, and that the checks were still running after the PR had already been merged.

Screen Shot 2022-11-15 at 10 34 44 PM

I have the following options enabled for my master branch protection:

Screen Shot 2022-11-15 at 10 45 54 PM

auto-merge.yaml:
Screen Shot 2022-11-15 at 10 48 51 PM

@kaankoken
Copy link

Maybe it is too late, but you have not add a status check for travis (the section that status checks that are required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants