Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to block if not all reviewers have approved #853

Open
tvuotila opened this issue Sep 16, 2020 · 0 comments · May be fixed by #1170
Open

Add option to block if not all reviewers have approved #853

tvuotila opened this issue Sep 16, 2020 · 0 comments · May be fixed by #1170

Comments

@tvuotila
Copy link

Use case: When we create a PR, we request review from one or two peers. It would be nice to wait for all of them to approve the PR before merging.

Solution proposal: Add option "maxPendingReviews". Settings that to 0 would require all of the reviewers to either approve or request changes to the PR. Combining it with setting "maxRequestedChanges" to 0 would require every reviewer to approve the PR.

For example

minApprovals:
  NONE: 1
maxRequestedChanges:
  NONE: 0
maxPendingReviews:
  NONE: 0
@renefritze renefritze mentioned this issue Nov 19, 2020
Merged
tvuotila added a commit to tvuotila/probot-auto-merge that referenced this issue May 5, 2022
@tvuotila
Add maxPendingReviews condition
84519d3 
Closes bobvanderlinden#853
@tvuotila tvuotila linked a pull request May 5, 2022 that will close this issue
Open
tvuotila added a commit to tvuotila/probot-auto-merge that referenced this issue May 5, 2022
@tvuotila
feat: maxPendingReviews condition
67da0b9 
Closes bobvanderlinden#853
tvuotila added a commit to tvuotila/probot-auto-merge that referenced this issue May 6, 2022
@tvuotila
feat: maxPendingReviews condition
0933815 
Closes bobvanderlinden#853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: maxPendingReviews condition tvuotila/probot-auto-merge
1 participant
@tvuotila