Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what would it take to utilize prompt-toolkit (or replicate its features)? #668

Open
ahillio opened this issue Feb 20, 2021 · 5 comments
Open

Comments

@ahillio
Copy link

ahillio commented Feb 20, 2021

Prompt Toolkit is an awesome library that enables really awesome things like a MySQL client with autocompletion, vi-mode, and more and a Python REPL with all those ++ awesome features.

I really want suggested autocompletion, vi-mode, history substring search (among other awesome features) in my php repl.

I have no idea what would be involved in utilizing Prompt Toolkit in PSYSH.

But I think it would be awesome.

@ahillio
Copy link
Author

ahillio commented Feb 20, 2021

#392 might benefit from this.

@ahillio
Copy link
Author

ahillio commented Mar 4, 2021

I'd gladly accept an answer (or guesstimate) in the form of a price tag :)

@bobthecow
Copy link
Owner

Yeah, that looks great :)

I'm not sure what it'd take, but it seems possible to do. To be perfectly honest, I don't have the bandwidth to take it on right now, but if you're interested in taking a shot at it, I'm happy to help with a game plan, review code, answer questions and give suggestions!

@ahillio
Copy link
Author

ahillio commented Mar 15, 2021

Sweet, I'm glad you like the idea, and it'd be super helpful to have some guidance in the process!

As far as the overall biggest-picture approach... would you consider completely replacing GNU Readline with python-prompt-toolkit?

@bobthecow
Copy link
Owner

Not as a hard dependency, no. But we currently support three different readline implementations for various reasons and adding a fourth for improved UX seems doable.

There's also a Jupyter notebook integration that might be useful or informative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants