Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Timerole - Separate add and remove functionality #170

Open
steelshot opened this issue Feb 21, 2021 · 1 comment
Open

Comments

@steelshot
Copy link

steelshot commented Feb 21, 2021

Currently if you try adding the same role both for addition and removal, you can add either or but not both.
For example:
A server has multi-tier roles ie. Tier-1, Tier-2, Tier-3, Tier-N.
If a server owner wants to assing a new tier and remove the old one persay going from T2 -> T3, the cog does not support that.

I think the simplest solution would be to under settings.json to not use a single group "roles" and "remove": true/false, but separating it into 2 groups "addroles" and "delroles". When the cog does the check it should most likely do the adds first and then the removals.
Another possible solution, to add another command argument for remove with addition after required roles. Though this would require some form of separation between required roles and remove with addition argument lists

@martin8883
Copy link

Previously I used an DeleteRole with one day delay. At some time I added "ExclusiveRole", to say which role overwrites which other roles. It´s not only a workaround but also helps to keep things tidy while manual role assignment.
I think I use it for more than two years now and it absolutely works great and even more reliable than timerole... It is also within Fox-V3. As of one of the unix principles to make a program one thing and to make it well, I would not extend timerole for this requirement.
Timerole T2 after x days [T1]
Timerole T3 after x days [T2]
Timerole T4 after x days [T3]
ExculsiveRole T2 overwrites [T1]
ExculsiveRole T3 overwrites [T2]
ExclusiveRole T4 overwrites [T3]

Just try it out, works great.

Regards
Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants