Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSS and GeSHi blocks to support loading src from a file #15

Open
2 of 3 tasks
bobbingwide opened this issue May 15, 2021 · 2 comments
Open
2 of 3 tasks
Assignees

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented May 15, 2021

Using the shared library logic developed in bobbingwide/oik-bob-bing-wide#40 for the CSV block, apply similar changes to the [bw_csv] and [bw_geshi] shortcodes and their associated blocks oik-css/css and oik-css/geshi.

Requirements

  • Improve the support for loading content from a source file rather than being entered into the block
  • Improve the blocks to add a text field used to identify the file to be loaded.

Proposed solution

  • Implement the shared library file libs/class-oik-attachment-contents.php
  • Add a text field in the Settings area to accept the attachment ID, URL or file name
  • Update documentation with appropriate examples
@bobbingwide
Copy link
Owner Author

Note: The PHPUnit test case for bw_geshi__example() has been wrong for quite a while. This will need to be corrected.

@bobbingwide
Copy link
Owner Author

oik-css v1.3.0 was released to oik-plugins on 16th May. This minor version was not available on wordpress.org
oik-css v2.0.0 was packaged on 31 Aug and is now on wordpress.org
There's no documentation for the src attribute... But I have used the attribute in the wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant