New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fee logic to smart contract #41

Open

boyuan-chen opened this issue Aug 26, 2024 · 1 comment · May be fixed by #43

Assignees

Contributor

boyuan-chen commented Aug 26, 2024 •

edited

Loading

Please remove the fee calculation logic from the backend service and move it to the smart contract.

I can think of the following functions that we need in our smart contracts:

We need to set the fee percentage
We need to withdraw the fees

The gateway should read the fee percentage from the smart contract instead of hardcoding it.

boyuan-chen assigned sk-enya

sk-enya linked a pull request

that will close this issue

🆙 Chore: packages & node update #43

Open

sk-enya commented Oct 21, 2024

Changes has been done under!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment