Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifier: GRIP dialect #25

Open
bwalsh opened this issue Nov 3, 2023 · 2 comments
Open

Simplifier: GRIP dialect #25

bwalsh opened this issue Nov 3, 2023 · 2 comments
Assignees

Comments

@bwalsh
Copy link
Contributor

bwalsh commented Nov 3, 2023

Please write up a use case that describes what this is and when / why to use it.

Use case

As a [role], when [this happens] in order to [describe outcome], the system needs to [feature description]

Implementation details

  • What it does, how to invoke it, etc...
@matthewpeterkort
Copy link
Collaborator

matthewpeterkort commented Nov 10, 2023

As a ACED IDP platform developer, in order to import edges and vertices into GRIP, source data files that adhere to the Iceberg schema must be able to be translated into the GRIP format.

For example GRIP vertex has keys {"label": str, "id": uuid , "data": dict} and edge has keys :{"label": str, "to": uuid, "from": uuid}.

The edge/vertex generation command looks for a directory and generates the edges/vertices that are applicable from the ndjson iceberg files located in the directory. It assumes that objects follow the schema provided using the --schema_path option and if they don't errors will occur.

iceberg data simplify tests/fixtures/simplify/synthea newobsss --schema_path https://raw.githubusercontent.com/bmeg/iceberg/main/schemas/graph/graph-fhir.json --dialect GRIP

Edge seems too slow to be a practical solution at scale. Need to think about how to make this faster.

Had to remove observation.ndjson because it was taking too much time to generate edges and DocumentReference.ndjson was causing schema errors.

@bwalsh
Copy link
Contributor Author

bwalsh commented Nov 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants