Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios document click #8

Open
bmcmahen opened this issue Sep 26, 2014 · 6 comments
Open

ios document click #8

bmcmahen opened this issue Sep 26, 2014 · 6 comments

Comments

@bmcmahen
Copy link
Owner

this doesn't register in safari ios. figure out a workaround

@bmcmahen
Copy link
Owner Author

used touchstart

@aghassipour
Copy link

That broke pinch to zoom on ios.

@bmcmahen
Copy link
Owner Author

bmcmahen commented Oct 3, 2014

hmm... guess i figured that no one would use pinch to zoom once the image was already zoomed in. But it makes sense. I'll reopen.

@bmcmahen bmcmahen reopened this Oct 3, 2014
@aghassipour
Copy link

Thanks. Not sure what adding docEvents.bind('touchstart', 'hide') fixes.
Testing without this line seems to work fine?

@bmcmahen
Copy link
Owner Author

bmcmahen commented Oct 3, 2014

the intended behaviour is that if you touch off the zoomed image, the zoomed image returns to its thumbnail state. This is how it works on the desktop, but iOS doesn't recognize a 'click' event bound to the document (it does, however, recognize a touchstart event). It's not a huge deal because you can still click on the zoomed image to return to the previous state, but I think it's a desirable feature.

@aghassipour
Copy link

Got it, thanks. Hmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants