Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused on_cancel Attribute in Dialog Component #100

Closed
DamascenoV opened this issue Dec 6, 2024 · 2 comments
Closed

Unused on_cancel Attribute in Dialog Component #100

DamascenoV opened this issue Dec 6, 2024 · 2 comments

Comments

@DamascenoV
Copy link
Contributor

In the Dialog component, the on_cancel attribute is declared but not used.
Is this intentional, or should it work similarly to the Modal component in the core_component?
Let me know if I can help!

Thanks!
@bluzky bluzky closed this as completed Dec 7, 2024
@bluzky
Copy link
Owner

bluzky commented Dec 7, 2024

Closed as merged #101

@bluzky
Copy link
Owner

bluzky commented Dec 7, 2024

Release 0.14.4 for this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bluzky @DamascenoV