Add sex to names (#474)

CodeWritingCow · arminkhoshbin · commit ec34399c0119 · 2017-11-11T18:18:40.000+10:00
* Add name "Jesus" * Fix ISO language code Use "cmn" for Chinese. * Lowercase name * Update 'Michael' Add aliases and translation. Merge "mitch" with "michael" because mitch is an alias for Michael. Delete "mitch.json." * Add gender to name file specs Add gender to file specs in readme.md. Add tests to validate each JSON's gender value. * Update michael.json Resolve merge conflict by using main repo's version of JSON file. * Make sex field optional for now Comment out tests for sex field. They are failing because names in collection don't have that field. Issue #443 * Add tests to check validity of gender Tests run only on name files that contain a gender value. Issue #443 Update README.md to describe sex field as optional. * Update gender tests - Issue #443 Sex field now requires a value to pass test. Also: - Add error messages to explain why a test failed. - Remove test for checking whether a sex value is a string. It's duplicating part of the "should have correct structure" test. * Add sex to 31 names Issue #456 * Add sex to 24 names Issue #456
diff --git a/collection/kevin.json b/collection/kevin.json
@@ -4,5 +4,6 @@
     "translations": {
         "por": "kevin",
         "heb": "קווין"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/kyle.json b/collection/kyle.json
@@ -4,5 +4,6 @@
     "aliases": [],
     "translations": {
         "heb": "קייל"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/lily.json b/collection/lily.json
@@ -4,5 +4,6 @@
     "aliases": [],
     "translations": {
         "heb": "לילי"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/luigi.json b/collection/luigi.json
@@ -3,5 +3,6 @@
     "meaning": "Renowned fighter. Form of the French Louis.",
     "translations": {
         "heb": "לואיג'י"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/luke.json b/collection/luke.json
@@ -13,5 +13,6 @@
         "gae": "lùc",
         "pol": "łukasz",
         "heb": "לוק"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/magnus.json b/collection/magnus.json
@@ -6,5 +6,6 @@
         "nno": "magnar",
         "rus": "магнус",
         "heb": "מגנוס"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/mahmud.json b/collection/mahmud.json
@@ -5,5 +5,6 @@
     "translations": {
         "ara": "محمود",
         "heb": "מחמוד"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/mario.json b/collection/mario.json
@@ -10,5 +10,6 @@
 		"rus": "марио",
 		"fas": "ماریو",
 		"heb": "מריו"
-	}
+	},
+	"sex": "m"
 }
diff --git a/collection/mark.json b/collection/mark.json
@@ -13,5 +13,6 @@
         "tha": "มาร์ค",
         "mkd": "марк",
         "heb": "מארק"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/martin.json b/collection/martin.json
@@ -10,5 +10,6 @@
         "mkd": "мартин",
         "tha": "มาติน",
         "heb": "מרטין"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/marvin.json b/collection/marvin.json
@@ -9,5 +9,6 @@
         "fas": "ماروین",
         "rus": "марвин",
         "heb": "מרווין"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/mary.json b/collection/mary.json
@@ -10,5 +10,6 @@
         "rus": "мария",
         "spa": "maría",
         "heb": "מרי"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/matilda.json b/collection/matilda.json
@@ -9,5 +9,6 @@
         "fra": "mathilde",
         "spa": "matilde",
         "heb": "מטילדה"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/matthew.json b/collection/matthew.json
@@ -16,5 +16,6 @@
         "rus": "мэттью",
         "mkd": "матеј",
         "por": "matheus"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/maurice.json b/collection/maurice.json
@@ -8,5 +8,6 @@
         "pol": "maurycy",
         "spa": "mauricio",
         "por": "mauricio"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/max.json b/collection/max.json
@@ -11,5 +11,6 @@
         "aze": "maks",
         "rus": "макс",
         "heb": "מקס"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/michael.json b/collection/michael.json
@@ -9,5 +9,6 @@
     "rus": "михаил",
     "pol": "michał",
     "heb": "מיכאל"
-  }
+  },
+  "sex": "m"
 }
diff --git a/collection/michelle.json b/collection/michelle.json
@@ -43,5 +43,6 @@
         "urd": "مشیل",
         "yid": "מישעל"
 
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/mikaela.json b/collection/mikaela.json
@@ -6,6 +6,7 @@
       "spa": "mikaela",
       "por": "mikaela",
       "heb": "מיכאלה"
-    }
+    },
+    "sex": "f"
   }
   
diff --git a/collection/mitch.json b/collection/mitch.json
@@ -4,5 +4,6 @@
     "transaltions": {
         "rus": "митч",
         "heb": "מיטש"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/natasha.json b/collection/natasha.json
@@ -8,5 +8,6 @@
         "kor": "나타샤",
         "lat": "natasha",
         "heb": "נטשה"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/nathaniel.json b/collection/nathaniel.json
@@ -5,5 +5,6 @@
     "translations": {
         "heb": "נתנאל",
         "pol": "nataniel"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/nicholas.json b/collection/nicholas.json
@@ -8,5 +8,6 @@
 	"srp": "nikola",
     "lat": "nicolaus",
     "heb": "ניוקולס"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/osman.json b/collection/osman.json
@@ -6,5 +6,6 @@
         "aze": "osman",
         "mkd": "осман",
         "rus": "осман"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/otavio.json b/collection/otavio.json
@@ -7,5 +7,6 @@
         "tatavio",
         "tato"
     ],
-    "translations": {}
+    "translations": {},
+    "sex": "m"
 }
diff --git a/collection/patrick.json b/collection/patrick.json
@@ -11,5 +11,6 @@
         "mkd": "патрик",
         "rus": "патрик",
         "heb": "פטריק"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/peter.json b/collection/peter.json
@@ -11,5 +11,6 @@
         "srb": "piter",
         "tha": "ปีเตอร์",
         "heb": "פטריק"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/philip.json b/collection/philip.json
@@ -6,5 +6,6 @@
         "ces": "filip",
         "rus": "филипп",
         "heb": "פיליפ"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/quentin.json b/collection/quentin.json
@@ -7,5 +7,6 @@
        "lat": "quintinus",
        "spa": "quintín",
        "heb": "קוונטין"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/rahul.json b/collection/rahul.json
@@ -9,5 +9,6 @@
     "jpn": "ラフル",
     "urd": "روح",
     "heb": "ראול"
-  }
+  },
+  "sex": "m"
 }
diff --git a/collection/rebecca.json b/collection/rebecca.json
@@ -11,5 +11,6 @@
         "dan": "rebekka",
         "nld": "rebekka",
         "spa": "rebeca"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/richard.json b/collection/richard.json
@@ -17,5 +17,6 @@
         "spa": "rico",
         "rus": "ричард",
         "heb": "ריצ'ארד"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/robert.json b/collection/robert.json
@@ -8,5 +8,6 @@
     ],
     "translations": {
         "heb": "רוברט"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/rory.json b/collection/rory.json
@@ -6,5 +6,6 @@
         "gla": "ruairidh",
         "heb": "רורי",
         "rus": "pори"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/ryan.json b/collection/ryan.json
@@ -9,5 +9,6 @@
     ],
     "translations": {
         "heb": "ריאן"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/saladin.json b/collection/saladin.json
@@ -6,5 +6,6 @@
     ],
     "translations": {
         "ara": "صلاح الدين"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/sam.json b/collection/sam.json
@@ -7,5 +7,6 @@
          "deu": "sam",
          "tha": "แซม",
          "heb": "סאם"
-     }
+     },
+     "sex": "m"
  }
diff --git a/collection/samantha.json b/collection/samantha.json
@@ -6,5 +6,6 @@
       "arb": "سامنتا",
       "rus": "саманта",
       "heb": "סמנת'ה"
-    }
+    },
+    "sex": "f"
   }
diff --git a/collection/sarah.json b/collection/sarah.json
@@ -6,5 +6,6 @@
 	],
 	"translations": {
 		"heb": "שרה"
-	}
+	},
+	"sex": "f"
 }
diff --git a/collection/sergey.json b/collection/sergey.json
@@ -15,5 +15,6 @@
         "pol": "siergiej",
         "mkd": "сергеј",
         "heb": "סרגיי"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/sophia.json b/collection/sophia.json
@@ -14,5 +14,6 @@
         "mkd": "софија",
         "srb": "sofija",
         "heb": "סופיה"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/sora.json b/collection/sora.json
@@ -5,5 +5,6 @@
         "jpn": "空",
         "jpn": "昊",
         "heb": "סורה"
-    }
+    },
+    "sex": "u"
 }
diff --git a/collection/stephen.json b/collection/stephen.json
@@ -7,5 +7,6 @@
   "translations": {
     "spa": "esteban",
     "heb": "סטפן"
-  }
+  },
+  "sex": "m"
 }
diff --git a/collection/steven.json b/collection/steven.json
@@ -10,5 +10,6 @@
   ],
   "translations": {
     "heb": "סטיבן"
-  }
+  },
+  "sex": "m"
 }
diff --git a/collection/svetlana.json b/collection/svetlana.json
@@ -10,5 +10,6 @@
         "mkd": "светлана",
         "hye": "սվետլանա",
         "heb": "סבטלנה"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/tatyana.json b/collection/tatyana.json
@@ -10,5 +10,6 @@
         "fas": "تاتیانا",
         "spa": "tatiana",
         "heb": "טאטיאנה"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/thomas.json b/collection/thomas.json
@@ -19,5 +19,6 @@
         "rus": "томас",
         "mkd": "томас",
         "heb": "תומאס"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/travis.json b/collection/travis.json
@@ -5,5 +5,6 @@
   "translations": {
 
     "rus": "трэвис"
-  }
+  },
+  "sex": "m"
 }
diff --git a/collection/trevor.json b/collection/trevor.json
@@ -6,5 +6,6 @@
 	],
 	"translations": {
 		"heb": "טרבור"
-	}
+	},
+	"sex": "m"
 }
diff --git a/collection/victoria.json b/collection/victoria.json
diff --git a/collection/vincent.json b/collection/vincent.json
diff --git a/collection/virgil.json b/collection/virgil.json
diff --git a/collection/wesley.json b/collection/wesley.json
diff --git a/collection/william.json b/collection/william.json
diff --git a/collection/xavier.json b/collection/xavier.json

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,6 @@`
`4`	`4`	`"translations": {`
`5`	`5`	`"por": "kevin",`
`6`	`6`	`"heb": "קווין"`
`7`		`- }`
	`7`	`+ },`
	`8`	`+ "sex": "m"`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,6 @@`
`4`	`4`	`"aliases": [],`
`5`	`5`	`"translations": {`
`6`	`6`	`"heb": "קייל"`
`7`		`- }`
	`7`	`+ },`
	`8`	`+ "sex": "m"`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,5 +3,6 @@`
`3`	`3`	`"meaning": "Renowned fighter. Form of the French Louis.",`
`4`	`4`	`"translations": {`
`5`	`5`	`"heb": "לואיג'י"`
`6`		`- }`
	`6`	`+ },`
	`7`	`+ "sex": "m"`
`7`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@`
`13`	`13`	`"gae": "lùc",`
`14`	`14`	`"pol": "łukasz",`
`15`	`15`	`"heb": "לוק"`
`16`		`- }`
	`16`	`+ },`
	`17`	`+ "sex": "m"`
`17`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,6 @@`
`6`	`6`	`"nno": "magnar",`
`7`	`7`	`"rus": "магнус",`
`8`	`8`	`"heb": "מגנוס"`
`9`		`- }`
	`9`	`+ },`
	`10`	`+ "sex": "m"`
`10`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,6 @@`
`5`	`5`	`"translations": {`
`6`	`6`	`"ara": "محمود",`
`7`	`7`	`"heb": "מחמוד"`
`8`		`- }`
	`8`	`+ },`
	`9`	`+ "sex": "m"`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,6 @@`
`10`	`10`	`"rus": "марио",`
`11`	`11`	`"fas": "ماریو",`
`12`	`12`	`"heb": "מריו"`
`13`		`- }`
	`13`	`+ },`
	`14`	`+ "sex": "m"`
`14`	`15`	`}`