Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Astro 3 #28

Open
bluwy opened this issue Oct 6, 2023 · 2 comments
Open

Support Astro 3 #28

bluwy opened this issue Oct 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bluwy
Copy link
Owner

bluwy commented Oct 6, 2023

WIP branch: https://github.com/bluwy/whyframe/tree/astro-3

I can't quite figure out the perfect way to support its new JSX support. In the branch, I updated docs/astro.config.mjs to support this new change, but it's a bit ugly.

React is hard to support now because it needs the preamble code in the client-side inside the iframe. Astro only adds the preamble code if there's an island in the frame page.

@bluwy bluwy added the enhancement New feature or request label Oct 6, 2023
@prodkt
Copy link

prodkt commented Oct 11, 2023

Any update on this?

@bluwy
Copy link
Owner Author

bluwy commented Oct 11, 2023

I haven't find the time to continue this, but feel free if you'd like to. The only thing missing is to get this preamble code injected into the iframe's html, through the @whyframe/astro plugin, for dev only.

The plugin could use the whyframe:app module and the transform hook to inject this preamble code to the page. However, I haven't tried this yet and whether this could be done cleanly. But at least copying the preamble code for now could be fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants