Add CMake option to disable building tests #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrickelectric Is there anyone on Blue Robotics who'd have time to review this? |
patrickelectric
approved these changes
Nov 12, 2024
|
Thanks for the PR @cdalke-havoc, sorry for missing it! |
|
@patrickelectric Thanks! sorry, just one more workflow approval if you don't mind, removed a log message so that this change doesn't add logging noise to other upstream projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a CMake option to toggle building the tests, which defaults to enabled. It's common for downstream projects to disable building the tests for external projects to reduce compile time.
By default,
PING_CPP_BUILD_TESTSis set toON, so the tests will still build.Consumers of the library who want to disable building the tests can set the option before including the project: