Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make k256 default precompile #1913

Closed
rakita opened this issue Dec 14, 2024 · 4 comments
Closed

Make k256 default precompile #1913

rakita opened this issue Dec 14, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@rakita
Copy link
Member

rakita commented Dec 14, 2024

This bench shows that k256 is faster than secp256k1 (C version): https://github.com/tarcieri/rust-secp256k1-ecdsa-bench. We should default to using it.

@rakita rakita added the good first issue Good for newcomers label Dec 14, 2024
@aguzmant103
Copy link

aguzmant103 commented Dec 17, 2024

@rakita I might be missing something but seems rust-secp256k1 is fastest right? Then k256 then parity's version libsec256k1. So we'd want to default the first one?
Also happy to take a stab at it! 🙋‍♂️

@Pana
Copy link
Contributor

Pana commented Dec 18, 2024

k256 and libsec256k1 are implemented in pure Rust

@FredCoen
Copy link
Contributor

once #1915 is merged should it default to rust-secp256k1 and not k256?

@rakita
Copy link
Member Author

rakita commented Dec 24, 2024

@aguzmant103 you are right I made mistake here, from graph [rust-secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) is fastest and should stay as default.

Will close this issue as @FredCoen is adding libsec256k1 support in #1915.

@rakita rakita closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants