Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover branches for databases that prefer unicode #109

Open
MathMagique opened this issue Jun 28, 2017 · 1 comment
Open

Cover branches for databases that prefer unicode #109

MathMagique opened this issue Jun 28, 2017 · 1 comment

Comments

@MathMagique
Copy link
Member

MathMagique commented Jun 28, 2017

A few code paths that handle ODBC's unicode columns are listed as not covered by our code coverage tool. The reason for this is that coverage information is collected on Linux and OSX only, and all databases they use run with prefer_unicode=False. The Windows builds do run tests with prefer_unicode=True, but they do not report coverage data.

Either have Windows builds report coverage data or let Linux/OSX builds run tests with prefer_unicode=True, which implies using an additional database.

@xhochy
Copy link
Collaborator

xhochy commented Jan 5, 2019

The simplest solution would be to also run MS SQL Tests on Linux. The MS SQL docker container makes this quite simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants