Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsfresh/docs/text/quick_start.rst does not reflect data #708

Open
danielfeinblatt opened this issue Jun 1, 2020 · 2 comments
Open

tsfresh/docs/text/quick_start.rst does not reflect data #708

danielfeinblatt opened this issue Jun 1, 2020 · 2 comments

Comments

@danielfeinblatt
Copy link

I recently started exploring tsfresh and began with the quickstart page. However, the instructions do not appear to reflect the data. I am happy to implement a change, but as I am new to the community, want to see what was intended. Specifically the y data in the mini-tutorial comes out as a series of type: bool, rather than integers as displayed in the page. Also, when following the plotting step, my plots have very little resemblance to those found on the page, which may be cause for confusion to many. It appears many of the plot formatting code was left out, which I assume is for clarity sake and to show the simplicity of tsfresh. However, I think it would be quite helpful to include for beginners to this package. I am using version 0.16.0 for reference, running in jupyter notebooks.

@nils-braun
Copy link
Collaborator

Hello @danielfeinblatt! Thanks for the issue.
Very good, we are very happy if you could fix this with a PR.
If possible, you can keep the plotting code at a minimum - even if the plots might change (but feel free to add as much plotting code as needed to convoy the message).
Thanks for looking into that.

@nils-braun
Copy link
Collaborator

@danielfeinblatt Did you had some time to look into this? Should we have a look at our side or will you find some time?
No pressure, we are more than happy if more people want to contribute! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants