Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or unittest index cast at the end of the feature extraction #706

Open
nils-braun opened this issue May 28, 2020 · 1 comment
Open

Comments

@nils-braun
Copy link
Collaborator

Are we testing the types of indices that need this recasting in some unit tests?
If not, do we actually need this line of casting?

Originally posted by @MaxBenChrist in #705

@dbarbier
Copy link
Contributor

IMHO this is the exact same problem as with sort_index; current code looks good, it seems natural to return a DataFrame with an index identical to df[column_id]. I do not see why this should be changed or tested, there is no test to ensure that index is sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants