Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beat the Y-1 baseline in Google Stock notebook #295

Open
lh14576 opened this issue Aug 14, 2017 · 2 comments
Open

beat the Y-1 baseline in Google Stock notebook #295

lh14576 opened this issue Aug 14, 2017 · 2 comments

Comments

@lh14576
Copy link

lh14576 commented Aug 14, 2017

Hi,
first I think this is an awesome project! However, I would like to see a notice on the Google Stock notebook that this is just a technical example but the results gained from this have no practical relevance whatsoever.

If we check whether the prediction got the direction of the next day correct it is just slightly below 50%.

Other than that plotting the next day's prediction will always look nice but just taking the last day's value as prediction looks even nicer ;)
So we can't really gain any information from that either.

google

On a different note I would love to see a notebook example on how to use tsfresh with keras

@MaxBenChrist
Copy link
Collaborator

Other than that plotting the next day's prediction will always look nice but just taking the last day's value as prediction looks even nicer ;)

We can the add MAE of both models, feature based adaboost and the Y-1. If the Y-1 is still better, then we need to tweak the adaboost more :D. However, this was only thought as an example how one can use feature to forecast time series and not as a investment model.

On a different note I would love to see a notebook example on how to use tsfresh with keras

You can just calculate the feature matrix and then pass it into your keras model.

@MaxBenChrist MaxBenChrist changed the title Google Stock notebook add Y-1 as baseline to Google Stock notebook Aug 14, 2017
@MaxBenChrist MaxBenChrist changed the title add Y-1 as baseline to Google Stock notebook beat the Y-1 baseline to Google Stock notebook Aug 17, 2017
@MaxBenChrist MaxBenChrist changed the title beat the Y-1 baseline to Google Stock notebook beat the Y-1 baseline in Google Stock notebook Aug 17, 2017
@MaxBenChrist
Copy link
Collaborator

out of the box, we are not beating the y-1 benchmark, which I added to the notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants