Skip to content
This repository has been archived by the owner on Jan 2, 2025. It is now read-only.

feat: allow scrolling #14

Closed
wants to merge 1 commit into from

Conversation

freak12techno
Copy link

@freak12techno freak12techno commented May 15, 2023

Fixes #10.

Now on pressing "up" or "down" buttons, it'll scroll to the top or the bottom. (Scrolling by 1 up or down is quite unintuitive, as it starts with selecting the 1st row, so if your screen fits 30 validators, you have to press down 29 times so it'll actually scroll on 30th, same with scrolling up).

I've also updated a splitVotes function to return the count of rows, as otherwise it may happen that columns do not have equal rows count, so when scrolling, one (fitting the screen) would be scrolled, and the other (not fitting the screen) would not, so we need to prefill the strings array with empty values to make it work properly

@freak12techno
Copy link
Author

@blockpane mind taking a look?

@freak12techno
Copy link
Author

@blockpane ping?

@freak12techno freak12techno deleted the allow-scrolling branch May 12, 2024 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validators list isn't fitting the screen when using smaller screens
1 participant