Skip to content

Commit d39c7f3

Browse files
robinboeningrobinboening
authored
Merge pull request #21 from lacepool/fix_tests
Fix test suite
2 parents debe8a5 + 38c2589 commit d39c7f3

10 files changed

+54
-64
lines changed

‎.env.example‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
BF_IPFS_PROJECT_ID=
22
BF_MAINNET_PROJECT_ID=
3-
BF_TESTNET_PROJECT_ID=
3+
BF_TESTNET_PROJECT_ID=

‎lib/blockfrostruby/endpoints/cardano/health_endpoints.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def get_root
1616
#
1717
# @return [Hash] formatted result with status and body keys.
1818
def get_health
19-
Request.get_response("#{@url}/health", @project_id)
19+
Request.get_response("#{@url}/health")
2020
end
2121

2222
# Calls get request on (@url)/health/clock.

‎lib/blockfrostruby/request.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class << self
1717
# @param project_id [String] the project_id to pass to url in headers.
1818
# @param params [Hash] params to add to request, allowed :order, :page, :count, :from, :to.
1919
# @return [Hash] formatted result with status and body keys.
20-
def get_response(url, project_id, params = {})
20+
def get_response(url, project_id = nil, params = {})
2121
params[:from_page] ? get_pages_multi(url, project_id, params) : get_response_from_url(url, project_id, params)
2222
end
2323

‎spec/endpoints/assets_endpoints_spec.rb‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
end
4646

4747
context 'with invalid asset' do
48-
it 'returns status 404, response body includes error' do
48+
it 'returns status 400, response body includes error' do
4949
response = blockfrost_mainnet.get_specific_asset(invalid_asset)
50-
expect(response[:status]).to eq(404)
50+
expect(response[:status]).to eq(400)
5151
expect(response[:body]).to include(:error)
5252
end
5353
end
@@ -72,16 +72,16 @@
7272

7373
context 'with invalid asset' do
7474
context 'without params' do
75-
it 'returns status 404, response body includes error' do
75+
it 'returns status 400, response body includes error' do
7676
response = blockfrost_mainnet.get_asset_history(invalid_asset)
77-
expect(response[:status]).to eq(404)
77+
expect(response[:status]).to eq(400)
7878
expect(response[:body]).to include(:error)
7979
end
8080
end
8181
context 'with params' do
82-
it 'returns status 404, response body includes error' do
82+
it 'returns status 400, response body includes error' do
8383
response = blockfrost_mainnet.get_asset_history(invalid_asset, { count: 7, page: 3 })
84-
expect(response[:status]).to eq(404)
84+
expect(response[:status]).to eq(400)
8585
expect(response[:body]).to include(:error)
8686
end
8787
end
@@ -107,16 +107,16 @@
107107

108108
context 'with invalid asset' do
109109
context 'without params' do
110-
it 'returns status 404, response body includes error' do
110+
it 'returns status 400, response body includes error' do
111111
response = blockfrost_mainnet.get_asset_transactions(invalid_asset)
112-
expect(response[:status]).to eq(404)
112+
expect(response[:status]).to eq(400)
113113
expect(response[:body]).to include(:error)
114114
end
115115
end
116116
context 'with params' do
117-
it 'returns status 404, response body includes error' do
117+
it 'returns status 400, response body includes error' do
118118
response = blockfrost_mainnet.get_asset_transactions(invalid_asset, { count: 7, page: 3 })
119-
expect(response[:status]).to eq(404)
119+
expect(response[:status]).to eq(400)
120120
expect(response[:body]).to include(:error)
121121
end
122122
end
@@ -142,16 +142,16 @@
142142

143143
context 'with invalid asset' do
144144
context 'without params' do
145-
it 'returns status 404, response body includes error' do
145+
it 'returns status 400, response body includes error' do
146146
response = blockfrost_mainnet.get_asset_addresses(invalid_asset)
147-
expect(response[:status]).to eq(404)
147+
expect(response[:status]).to eq(400)
148148
expect(response[:body]).to include(:error)
149149
end
150150
end
151151
context 'with params' do
152-
it 'returns status 404, response body includes error' do
152+
it 'returns status 400, response body includes error' do
153153
response = blockfrost_mainnet.get_asset_addresses(invalid_asset, { count: 7, page: 3 })
154-
expect(response[:status]).to eq(404)
154+
expect(response[:status]).to eq(400)
155155
expect(response[:body]).to include(:error)
156156
end
157157
end
@@ -177,16 +177,16 @@
177177

178178
context 'with invalid policy_id' do
179179
context 'without params' do
180-
it 'returns status 404, response body includes error' do
180+
it 'returns status 400, response body includes error' do
181181
response = blockfrost_mainnet.get_assets_of_policy(invalid_policy_id)
182-
expect(response[:status]).to eq(404)
182+
expect(response[:status]).to eq(400)
183183
expect(response[:body]).to include(:error)
184184
end
185185
end
186186
context 'with params' do
187-
it 'returns status 404, response body includes error' do
187+
it 'returns status 400, response body includes error' do
188188
response = blockfrost_mainnet.get_assets_of_policy(invalid_policy_id, { count: 7, page: 3 })
189-
expect(response[:status]).to eq(404)
189+
expect(response[:status]).to eq(400)
190190
expect(response[:body]).to include(:error)
191191
end
192192
end

‎spec/endpoints/blocks_endpoints_spec.rb‎

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@
4949
end
5050
end
5151
context 'with invalid hash_or_number' do
52-
it 'returns status 404, response body includes error' do
52+
it 'returns status 400, response body includes error' do
5353
response = blockfrost_mainnet.get_block(invalid_hash_or_number)
54-
expect(response[:status]).to eq(404)
54+
expect(response[:status]).to eq(400)
5555
expect(response[:body]).to include(:error)
5656
end
5757
end
@@ -65,10 +65,9 @@
6565
end
6666
end
6767
context 'with invalid slot number' do
68-
it 'returns status 404, response body includes error' do
69-
skip 'Returns 500 instead of 404'
68+
it 'returns status 400, response body includes error' do
7069
response = blockfrost_mainnet.get_block_in_slot(invalid_slot_number)
71-
expect(response[:status]).to eq(404)
70+
expect(response[:status]).to eq(400)
7271
expect(response[:body]).to include(:error)
7372
end
7473
end
@@ -82,10 +81,9 @@
8281
end
8382
end
8483
context 'with invalid slot and epoch number' do
85-
it 'returns status 404, response body includes error' do
86-
skip 'Returns 500 instead of 404'
84+
it 'returns status 400, response body includes error' do
8785
response = blockfrost_mainnet.get_block_in_slot_in_epoch(invalid_slot_number, invalid_epoch_number)
88-
expect(response[:status]).to eq(404)
86+
expect(response[:status]).to eq(400)
8987
expect(response[:body]).to include(:error)
9088
end
9189
end
@@ -109,9 +107,9 @@
109107
end
110108
end
111109
context 'with invalid hash_or_number' do
112-
it 'returns status 404, response body includes error' do
110+
it 'returns status 400, response body includes error' do
113111
response = blockfrost_mainnet.get_list_of_next_blocks(invalid_hash_or_number)
114-
expect(response[:status]).to eq(404)
112+
expect(response[:status]).to eq(400)
115113
expect(response[:body]).to include(:error)
116114
end
117115
end
@@ -135,9 +133,9 @@
135133
end
136134
end
137135
context 'with invalid hash_or_number' do
138-
it 'returns status 404, response body includes error' do
136+
it 'returns status 400, response body includes error' do
139137
response = blockfrost_mainnet.get_list_of_previous_blocks(invalid_hash_or_number)
140-
expect(response[:status]).to eq(404)
138+
expect(response[:status]).to eq(400)
141139
expect(response[:body]).to include(:error)
142140
end
143141
end
@@ -161,9 +159,9 @@
161159
end
162160
end
163161
context 'with invalid hash_or_number' do
164-
it 'returns status 404, response body includes error' do
162+
it 'returns status 400, response body includes error' do
165163
response = blockfrost_mainnet.get_block_transactions(invalid_hash_or_number)
166-
expect(response[:status]).to eq(404)
164+
expect(response[:status]).to eq(400)
167165
expect(response[:body]).to include(:error)
168166
end
169167
end

‎spec/endpoints/health_endpoints_spec.rb‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
RSpec.describe HealthEndpoints do
88
let(:blockfrost_mainnet) { Blockfrostruby::CardanoMainNet.new(ENV['BF_MAINNET_PROJECT_ID']) }
99
let(:blockfrost_mainnet_invalid) { Blockfrostruby::CardanoMainNet.new('invalid project_id') }
10-
let(:blockfrost_testnet) { Blockfrostruby::CardanoTestNet.new(ENV['BF_TESTNET_PROJECT_ID']) }
11-
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoTestNet.new('invalid project_id') }
10+
let(:blockfrost_testnet) { Blockfrostruby::CardanoPreview.new(ENV['BF_TESTNET_PROJECT_ID']) }
11+
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoPreview.new('invalid project_id') }
1212

1313
context 'CardanoMainNet object' do
1414
context 'with valid project_id' do
@@ -39,16 +39,16 @@
3939

4040
context 'with invalid project_id' do
4141
context 'when calls get_health method' do
42-
it 'returns 403 status and body includes error' do
42+
it 'return status 200 and is_healthy => true' do
4343
response = blockfrost_mainnet_invalid.get_health
44-
expect(response[:status]).to eq(403)
45-
expect(response[:body]).to include(:error)
44+
expect(response[:status]).to eq(200)
45+
expect(response[:body]).to eq({ is_healthy: true })
4646
end
4747
end
4848
end
4949
end
5050

51-
context 'CardanoTestNet object' do
51+
context 'CardanoPreview object' do
5252
context 'with valid project_id' do
5353
context 'when calls get_health method' do
5454
it 'return status 200 and is_healthy => true' do
@@ -77,10 +77,10 @@
7777

7878
context 'with invalid project_id' do
7979
context 'when calls get_health method' do
80-
it 'returns 403 status and body includes error' do
80+
it 'return status 200 and is_healthy => true' do
8181
response = blockfrost_testnet_invalid.get_health
82-
expect(response[:status]).to eq(403)
83-
expect(response[:body]).to include(:error)
82+
expect(response[:status]).to eq(200)
83+
expect(response[:body]).to eq({ is_healthy: true })
8484
end
8585
end
8686
end

‎spec/endpoints/ledger_endpoints_spec.rb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
RSpec.describe LedgerEndpoints do
88
let(:blockfrost_mainnet) { Blockfrostruby::CardanoMainNet.new(ENV['BF_MAINNET_PROJECT_ID']) }
99
let(:blockfrost_mainnet_invalid) { Blockfrostruby::CardanoMainNet.new('invalid project_id') }
10-
let(:blockfrost_testnet) { Blockfrostruby::CardanoTestNet.new(ENV['BF_TESTNET_PROJECT_ID']) }
11-
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoTestNet.new('invalid project_id') }
10+
let(:blockfrost_testnet) { Blockfrostruby::CardanoPreview.new(ENV['BF_TESTNET_PROJECT_ID']) }
11+
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoPreview.new('invalid project_id') }
1212

1313
context 'CardanoMainNet object' do
1414
context 'with valid project_id' do
@@ -32,7 +32,7 @@
3232
end
3333
end
3434

35-
context 'CardanoTestNet object' do
35+
context 'CardanoPreview object' do
3636
context 'with valid project_id' do
3737
context 'when calls get_genesis method' do
3838
it 'return status 200 and response body includes active_slots_coefficient' do

‎spec/endpoints/metrics_endpoints_spec.rb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
RSpec.describe MetricsEndpoints do
88
let(:blockfrost_mainnet) { Blockfrostruby::CardanoMainNet.new(ENV['BF_MAINNET_PROJECT_ID']) }
99
let(:blockfrost_mainnet_invalid) { Blockfrostruby::CardanoMainNet.new('invalid project_id') }
10-
let(:blockfrost_testnet) { Blockfrostruby::CardanoTestNet.new(ENV['BF_TESTNET_PROJECT_ID']) }
11-
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoTestNet.new('invalid project_id') }
10+
let(:blockfrost_testnet) { Blockfrostruby::CardanoPreview.new(ENV['BF_TESTNET_PROJECT_ID']) }
11+
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoPreview.new('invalid project_id') }
1212

1313
context 'CardanoMainNet object' do
1414
context 'with valid project_id' do
@@ -38,7 +38,7 @@
3838
end
3939
end
4040

41-
context 'CardanoTestNet object' do
41+
context 'CardanoPreview object' do
4242
context 'with valid project_id' do
4343
context 'when calls get_metrics method' do
4444
it 'return status 200' do

‎spec/endpoints/network_endpoints_spec.rb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
RSpec.describe NetworkEndpoints do
88
let(:blockfrost_mainnet) { Blockfrostruby::CardanoMainNet.new(ENV['BF_MAINNET_PROJECT_ID']) }
99
let(:blockfrost_mainnet_invalid) { Blockfrostruby::CardanoMainNet.new('invalid project_id') }
10-
let(:blockfrost_testnet) { Blockfrostruby::CardanoTestNet.new(ENV['BF_TESTNET_PROJECT_ID']) }
11-
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoTestNet.new('invalid project_id') }
10+
let(:blockfrost_testnet) { Blockfrostruby::CardanoPreview.new(ENV['BF_TESTNET_PROJECT_ID']) }
11+
let(:blockfrost_testnet_invalid) { Blockfrostruby::CardanoPreview.new('invalid project_id') }
1212

1313
context 'CardanoMainNet object' do
1414
context 'with valid project_id' do

‎spec/endpoints/nutlink_endpoints_spec.rb‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,17 @@
66

77
RSpec.describe NutlinkEndpoints do
88
let(:blockfrost_mainnet) { Blockfrostruby::CardanoMainNet.new(ENV['BF_MAINNET_PROJECT_ID']) }
9-
let(:blockfrost_mainnet_invalid) { Blockfrostruby::CardanoMainNet.new('invalid project_id') }
109

11-
let(:valid_address) { 'addr1qxqs59lphg8g6qndelq8xwqn60ag3aeyfcp33c2kdp46a09re5df3pzwwmyq946axfcejy5n4x0y99wqpgtp2gd0k09qsgy6pz' }
12-
let(:invalid_address) { 'invalid_number' }
13-
let(:valid_ticker) { 'valid_ticker' }
14-
let(:invalid_ticker) { 'invalid_number' }
10+
let(:valid_address) { 'addr1q85yx2w7ragn5sx6umgmtjpc3865s9sg59sz4rrh6f90kgwfwlzu3w8ttacqg89mkdgwshwnplj5c5n9f8dhp0h55q2q7qm63t' }
11+
let(:invalid_address) { 'invalid' }
12+
let(:valid_ticker) { 'ADABTC' }
13+
let(:invalid_ticker) { 'invalid' }
1514

1615
context 'CardanoMainNet object' do
1716
context 'with valid project_id' do
1817
context 'when calls get_address_metadata_list method' do
1918
context 'with valid address' do
2019
it 'returns status 200' do
21-
skip 'Return 404 now'
2220
response = blockfrost_mainnet.get_address_metadata_list(valid_address)
2321
expect(response[:status]).to eq(200)
2422
end
@@ -36,14 +34,12 @@
3634
context 'with valid address' do
3735
context 'without params' do
3836
it 'returns status 200' do
39-
skip 'Return 404 now'
4037
response = blockfrost_mainnet.get_address_metadata_tickers_list(valid_address)
4138
expect(response[:status]).to eq(200)
4239
end
4340
end
4441
context 'with params { count: 5 }' do
4542
it 'returns status 200' do
46-
skip 'Return 404 now'
4743
response = blockfrost_mainnet.get_address_metadata_tickers_list(valid_address, { count: 5 })
4844
expect(response[:status]).to eq(200)
4945
end
@@ -62,14 +58,12 @@
6258
context 'with valid address and ticker' do
6359
context 'without params' do
6460
it 'returns status 200' do
65-
skip 'Return 404 now'
6661
response = blockfrost_mainnet.get_ticker_records_by_address(valid_address, valid_ticker)
6762
expect(response[:status]).to eq(200)
6863
end
6964
end
7065
context 'with params { count: 5 }' do
7166
it 'returns status 200' do
72-
skip 'Return 404 now'
7367
response = blockfrost_mainnet.get_ticker_records_by_address(valid_address, valid_ticker, { count: 5 })
7468
expect(response[:status]).to eq(200)
7569
end
@@ -88,14 +82,12 @@
8882
context 'with valid address and ticker' do
8983
context 'without params' do
9084
it 'returns status 200' do
91-
skip 'Return 404 now'
9285
response = blockfrost_mainnet.get_ticker_records(valid_ticker)
9386
expect(response[:status]).to eq(200)
9487
end
9588
end
9689
context 'with params { count: 5 }' do
9790
it 'returns status 200' do
98-
skip 'Return 404 now'
9991
response = blockfrost_mainnet.get_ticker_records(valid_ticker, { count: 5 })
10092
expect(response[:status]).to eq(200)
10193
end

0 commit comments

Comments
 (0)