Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressService#getAllAddressUtxos does not return datum hashes as outlined in API spec #7

Open
will-break-it opened this issue Aug 29, 2022 · 4 comments

Comments

@will-break-it
Copy link

According to the OpenAPI specifications this endpoint should return data_hash, inline_datum and other script output related fields.
Unfortunately, it doesn't. Perhaps a new version needs to be released to match the documentation.

@bentaye
Copy link
Contributor

bentaye commented Aug 30, 2022

I'd add reference_script_hash to the list of missing fields

This is the class I think, it seems that the 3 fields are missing

public class AddressUtxo {
    /**
     * Transaction hash of the UTXO
     */
    private String txHash;
    /**
     * UTXO index in the transaction
     */
    private Integer outputIndex;
    /**
     * Array of TransactionOutputAmount objects
     */
    private List<TransactionOutputAmount> amount = new ArrayList<TransactionOutputAmount>();
    /**
     * Block number of the UTXO
     */
    private String block;

}

https://github.com/blockfrost/blockfrost-java/blob/master/src/main/java/io/blockfrost/sdk/api/model/AddressUtxo.java

@satran004
Copy link
Collaborator

satran004 commented Aug 31, 2022

@bentaye Yes the missing fields need to be added to AddressUtxo.java .
You can find the field definitions for this object here in openapi yml
https://github.com/blockfrost/openapi/blob/a025b0a994eaea80dcd1a575f54704d7aaffc9da/openapi.yaml#L6950

@bentaye
Copy link
Contributor

bentaye commented Aug 31, 2022

I opened a PR here #8

@bentaye
Copy link
Contributor

bentaye commented Sep 7, 2022

@will991 The PR with the new fields have been merge, please check if it is all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants