Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General font size and other small suggestions #70

Open
velitasali opened this issue Nov 16, 2021 · 5 comments
Open

General font size and other small suggestions #70

velitasali opened this issue Nov 16, 2021 · 5 comments

Comments

@velitasali
Copy link

Hi again, and thanks for creating this font :)

I would like to make some of my issues known and suggest some changes that may improve the look of the font. I am aware that these may be considered subjective, so I will be okay if some of them (if not all) might not be implemented.

Size

Agave looks smaller on the UI compared to other fonts that came out recently. This affects how IDE presents other information, e.g., inlay hints. (I think Ubuntu Mono and Sudo also suffer from this.)

I think it would be great if the font size matched other fonts when set to appear the same size.

Size Comparison

Screenshot from 2021-11-16 14-55-08
Screenshot from 2021-11-16 14-55-30

Inlay Hints

Notice how inlay hints are almost the same size as the actual code with Agave. BTW, inlay hints are the ones that say ^OnItemViewClickedListener here.

Screenshot from 2021-11-16 14-56-10
Screenshot from 2021-11-16 14-56-55

Glyphs

Parentheses

The top and bottom edges of ( and ) look too sharp, possibly due to hinting.

Screenshot from 2021-11-16 15-10-02

I think that can be improved by changing them like this:

Screenshot from 2021-11-16 15-11-15

The original looks like this:

Screenshot from 2021-11-16 15-11-22

Ampersand

The sharp edges of ampersand gives it a bad look on smaller sizes. Either fully disconnecting or fully connecting the bottom edge should improve its look.

Screenshot from 2021-11-16 15-17-49

It can be changed like this:

Screenshot from 2021-11-16 15-20-24

The original looks like this:

Screenshot from 2021-11-16 15-21-19

Curly brackets

The same can be applied here. Too small corners are not drawn as pixels. Giving them more room may be a good idea.

Conclusion

I am not a designer but someone who tinkers with fonts a lot. Again, these are highly subjective, so if you decide to reject the idea, know that I will be okay :)

Thanks!

@blobject
Copy link
Owner

Hi, thank you very much for the feedback.

size: I will need to see if there's a general setting I can tweak, although I doubt that the letters can be made to look bigger as I've just used the standard box height of 2048 and worked within that. Sometimes, fonts seem to optimise to ASCII, and have accents/diacritics protude past the bounding box. I chose not to do that. I'll look to see if this is what Cascadia (and others) has done.

parentheses: I agree with this. Created new issue: #71

ampersand: A new design of the ampersand is being considered. I've never been too satisfied with the current design, but it was much easier to create :-P. The relevant issue is: #58

(curly) brace: Yes, I will include your note in this issue: #59

Overall, it's nice to get opinions from a user and I generally agree with your assessments. There are several design tweaks and improvements, including your suggestions here, under way, and they should all show up in the next revision. Unfortunately, I've been much too busy lately so I don't know when that will come out.

@velitasali
Copy link
Author

Thanks for the consideration. As you said, 2048 pixels seems to be one of the conventional heights. Cascadia also uses 2048 pixels as the total height, so I am not sure what is causing the difference.

Btw, sorry about the duplicated suggestions, I should have checked for existing issues.

@blobject
Copy link
Owner

I took a glance at Cascadia's geometry. If you look at the screenshot (Cascadia left, Agave right), you will notice that the area that Cascadia allocates to descenders is shorter and they let diacritics overshoot the bounding box.

a

One of agave's design tenets is regularity, and I chose the dimensions accordingly. I even made squished versions of latin capitals to adhere to that regularity (As seen in the screenshot, the squished/stubbier "A" is called "Aduck"). I'm afraid getting the kind of size you want out of Agave will require an overhaul of the dimensions, which I am wary of doing, sorry. But I'll look around a bit more in case there's something else to be done.

No worries about duplicated suggestions!

@velitasali
Copy link
Author

I see. Thanks for the explanation. I am guessing this issue can be closed since all the other suggestions have their respective threads.

Cheers.

@blobject
Copy link
Owner

I'll research the font size issue a bit more, and close this if I have no further comments/changes to make. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants