Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blitz new generating wrong form package #4357

Open
calebhyatt opened this issue Jul 11, 2024 · 3 comments
Open

blitz new generating wrong form package #4357

calebhyatt opened this issue Jul 11, 2024 · 3 comments
Labels
good first issue Good for newcomers kind/bug Something isn't working status/triage

Comments

@calebhyatt
Copy link

What is the problem?

When generating a new Blitz application I chose React Hook Form for my form package. However, it still went ahead and gave me Formik.

I'm assuming it's not a create-T3-app JavaScript-type joke where I have to use Formik against my will.

Paste all your error logs here:

Screenshot 2024-07-11 at 9 19 25 AM

Paste all relevant code snippets here:

Screenshot 2024-07-11 at 9 19 38 AM

What are detailed steps to reproduce this?

  1. Create a new Blitz app
  2. Choose App Router template
  3. Use pnpm to install dependencies
  4. Choose React Hook Form for form library

Run blitz -v and paste the output here:

Blitz version: 2.0.10 (global)
Blitz version: 2.0.10 (local)
macOS Sonoma | darwin-x64 | Node: v20.13.0

 Package manager: pnpm

  System:
    OS: macOS 14.5
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 5.04 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.13.0 - ~/.nvm/versions/node/v20.13.0/bin/node
    Yarn: 1.22.22 - /usr/local/bin/yarn
    npm: 10.5.2 - ~/.nvm/versions/node/v20.13.0/bin/npm
  npmPackages:
    @blitzjs/auth: 2.0.10 => 2.0.10 
    @blitzjs/next: 2.0.10 => 2.0.10 
    @blitzjs/rpc: 2.0.10 => 2.0.10 
    @prisma/client: 5.4.2 => 5.4.2 
    blitz: 2.0.10 => 2.0.10 
    next: 14.1.4 => 14.1.4 
    prisma: 5.4.2 => 5.4.2 
    react: 18.2.0 => 18.2.0 
    react-dom: 18.2.0 => 18.2.0 
    typescript: ^4.8.4 => 4.9.5

Please include below any other applicable logs and screenshots that show your problem:

pnpm version: 9.1.0
Node.js version: 20.13.0
npm version: 10.5.2

@calebhyatt calebhyatt added kind/bug Something isn't working status/triage labels Jul 11, 2024
@Kosai106
Copy link
Contributor

Here's the reason: https://github.com/blitz-js/blitz/blob/main/packages/generator/templates/app/package.ts.json#L33

The app template is using formik by default despite what is selected during the setup.

@siddhsuresh siddhsuresh added the good first issue Good for newcomers label Sep 29, 2024
@rehanganapathy
Copy link

hey there, this seems like something i could work on, could you please assign it to me?

@Kosai106
Copy link
Contributor

Related ticket: #4337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working status/triage
Projects
None yet
Development

No branches or pull requests

4 participants