Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make Husky an optional install? #4277

Open
openspaceranger opened this issue Jan 14, 2024 · 3 comments
Open

Can we make Husky an optional install? #4277

openspaceranger opened this issue Jan 14, 2024 · 3 comments

Comments

@openspaceranger
Copy link

What do you want and why?

I was unable to fix the "command not found" problem with Husky. Until I uninstalled it, I was unable to make a git commit.

Possible implementation(s)

I'm not sure if it's possible without removing it, but it would it nice if it didn't interfere with anything for people who are not interested in it.

Additional context

As a new blitz user, Husky and node-gyp gave me headaches. A lot of people would have simply just given up and used Nextjs instead. I strongly feel that it hinders new adopters of Blitz.

@tordans
Copy link
Contributor

tordans commented Jan 14, 2024

Also ping #3981 (comment) which was closed in a recent "close all old issues"-run.

@tordans
Copy link
Contributor

tordans commented Jan 14, 2024

Personally, I recommend changing pre-commit to pre-push which still gives the security to not push without running checks but allows for WIP commits without extra work (like git commit --no-verify).

@siddhsuresh
Copy link
Member

siddhsuresh commented Jan 14, 2024

sorry about the experience @openspaceranger, we are addressing the node-gyp issue currently and will be fixed in the next version.

Regarding husky, we will need to discuss it, since I see that there were plans to remove it in its entirety from the new template.

Another option that comes to mind, would be to add it as step in the onboarding generator and the user can choose to include these optional nice-to-have configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants