Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube modal should autoplay video when triggered #189

Open
jeremydw opened this issue Dec 1, 2021 · 4 comments
Open

YouTube modal should autoplay video when triggered #189

jeremydw opened this issue Dec 1, 2021 · 4 comments
Assignees

Comments

@jeremydw
Copy link
Member

jeremydw commented Dec 1, 2021

Just saw it staged on the starter:
https://blinkk.github.io/amagaki-starter/

When the video button is clicked and the modal opens, the video should autoplay.

@uxder
Copy link
Member

uxder commented Dec 1, 2021

I tried this in Chrome, Safari, Android, changing network speeds etc but couldn't replicate it.

The only one I haven't tried is iOS. Is this where you are seeing the issue?

@uxder
Copy link
Member

uxder commented Dec 1, 2021

Okay, looks like I need to transfer this logic over to the new youtube modal component.

    if (this.config.useHandlerOnMobile && (is.ios() || is.android())) {
      let redirectUrl = `https://m.youtube.com/watch?v=${videoId}`;
      if (options.startTime) {
        redirectUrl = `${redirectUrl}&t=${options.startTime}s`;
      }
      window.location.href = redirectUrl;
      return;
    }

@uxder uxder self-assigned this Dec 1, 2021
@jeremydw
Copy link
Member Author

jeremydw commented Dec 1, 2021

Just on desktop Chrome:
Version 95.0.4638.69 (Official Build) (x86_64)

@uxder
Copy link
Member

uxder commented Jan 6, 2022

I might need to ask you to investigate this one. I've checked on three computers (Chrome) but have yet to replicate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants