Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel BEFORE_CHANGE fires in confusing situations #129

Open
angusm opened this issue Jul 27, 2021 · 0 comments
Open

Carousel BEFORE_CHANGE fires in confusing situations #129

angusm opened this issue Jul 27, 2021 · 0 comments
Assignees

Comments

@angusm
Copy link
Member

angusm commented Jul 27, 2021

The BEFORE_CHANGE event fires when a new transitionTarget is assigned.

This is confusing when the transitionTarget matches the currently active slide.

transitionTarget can be assigned matching the currently active slide to support situations where a draggable slide has been moved a bit, but not enough to change the active slide, and it needs to transition back to center.

The naming of BEFORE_CHANGE in this circumstance is confusing. It is probably worth splitting this into two events BEFORE_CHANGE and BEFORE_TRANSITION, firing one or both as necessary. This would also apply to AFTER events.

@angusm angusm self-assigned this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant