Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitHub Workflow for running tests #18

Open
vr-varad opened this issue Jun 22, 2024 · 9 comments
Open

Adding GitHub Workflow for running tests #18

vr-varad opened this issue Jun 22, 2024 · 9 comments

Comments

@vr-varad
Copy link

Set up GitHub Actions for CI (tests on PRs) and CD (deploy on pushes).

@blenderskool
Copy link
Owner

Could you elaborate a bit more? There's already auto deploy configured on Vercel. There are no tests in the repository right now (would be a good idea to add it) for the CI workflow

@vr-varad
Copy link
Author

Like while adding code to codebase we can check for lining errors, we can run code that has been changed by contributor to check for errors before adding it to code base,

@vr-varad
Copy link
Author

We can add tests and if someone contributes to code, as soon as they add make a pr we can test it and if there is any error he/she will know we don't have to manually check code for correctness

@blenderskool
Copy link
Owner

Got it, this workflow makes sense. But it also requires us to have some testing setup in place which is missing right now 😅. It would better if we can setup unit testing(possibly with vitest) in compiler and editor with some unit tests to go with it before adding the workflow for it.

@vr-varad
Copy link
Author

vr-varad commented Jun 22, 2024

okay!! Can u assign me this issue?
How about using jest or mocha chai which is more used?

@blenderskool
Copy link
Owner

Let me create a new issue for testing setup. This issue was for discussing GitHub workflows.

@vr-varad
Copy link
Author

cool

@vr-varad
Copy link
Author

@blenderskool can I start working on testing?

@blenderskool
Copy link
Owner

The issue for unit testing setup has been created here – #19.
It also has some points on why Vitest is preferred for this project.

@blenderskool blenderskool changed the title Adding Workflow for CICD Adding GitHub Workflow for running tests Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants