Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #2

Closed
wants to merge 0 commits into from
Closed

Conversation

AaronSMathew
Copy link
Collaborator

Solved The Issue On Dark Mode

@adhilsalim
Copy link
Member

Great work @AaronSMathew !!
Here are a few suggestions I have, @AaronSMathew . If possible, consider integrating a dark mode API for a sleeker interface. Additionally, implementing a toggle button to visually represent the current state would enhance user experience. Feel free to explore these ideas after your series exams. Good luck! 😊 @AkhilLV

@adhilsalim adhilsalim requested a review from AkhilLV October 9, 2023 13:51
@AaronSMathew
Copy link
Collaborator Author

Will check it out and update boss

@AkhilLV
Copy link
Contributor

AkhilLV commented Oct 9, 2023

Hey @AaronSMathew couple things:

  1. Consider using an auto-formatter like prettier to ensure code consistency
  2. Move the css and js to their own separate files
  3. Consider using event listeners within JS rather than inline listeners

As for the design, I will try making a sample design tomorrow for the dark mode

@AkhilLV
Copy link
Contributor

AkhilLV commented Oct 9, 2023

Also I am pretty sure header tags are supposed to be used within the body tag

@AkhilLV
Copy link
Contributor

AkhilLV commented Oct 9, 2023

@AaronSMathew @adhilsalim
https://www.figma.com/file/sgGS0WxTywGgcfZOLF9eCc/blankspace?type=design&node-id=0%3A1&mode=design&t=0MVpxjB0xdtIhSBF-1

I have linked a figma file please see if you can access it.

I can help on creating these dark mode classes
image

@AkhilLV AkhilLV linked an issue Oct 9, 2023 that may be closed by this pull request
@AkhilLV
Copy link
Contributor

AkhilLV commented Oct 10, 2023

@AaronSMathew I have added the dark mode classes for the project tags at the end of style.css
All the dark mode classes have a -dark suffixed to them

So enabling dark mode should just be a matter of adding and removing the -dark suffix from relevant elements on toggle

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for comfy-fudge-8246b2 ready!

Name Link
🔨 Latest commit 89224f8
🔍 Latest deploy log https://app.netlify.com/sites/comfy-fudge-8246b2/deploys/6531507e37ef960008d26a7b
😎 Deploy Preview https://deploy-preview-2--comfy-fudge-8246b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode
3 participants