Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

️🛠 - Clean up error handling #26

Open
3 tasks done
maxwellmattryan opened this issue Jul 25, 2024 · 0 comments
Open
3 tasks done

️🛠 - Clean up error handling #26

maxwellmattryan opened this issue Jul 25, 2024 · 0 comments
Assignees
Labels
type : refactor Improves existing code

Comments

@maxwellmattryan
Copy link
Contributor

Description

Errors need to be handled more cleanly and at a higher level in the library / program. Use Result for error handling. Propagate errors using ? operator and handle them at a higher level.

Use assertions (assert!, debug_assert!) for development and debugging. debug_assert! is removed in release builds, making it suitable for checks that are too costly in production.

A missing file is an error, not a bug, and the program should deal with it. Trying to de-reference a null pointer is a bug, and the program should acknowledge that something smells like bad cheese.

Requirements

TBD

Checklist

  • I have linked the correct milestone and/or project(s)
  • I have added the appropriate labels
  • I have assigned this task to the correct people
@maxwellmattryan maxwellmattryan added the type : refactor Improves existing code label Jul 25, 2024
@maxwellmattryan maxwellmattryan added this to the M1 - Library MVP milestone Jul 25, 2024
@maxwellmattryan maxwellmattryan self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type : refactor Improves existing code
Projects
None yet
Development

No branches or pull requests

1 participant