Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Paxmod #500

Open
surapunoyousei opened this issue Nov 2, 2022 · 12 comments
Open

Support Paxmod #500

surapunoyousei opened this issue Nov 2, 2022 · 12 comments
Labels
Issue::Enhancement New feature or request

Comments

@surapunoyousei
Copy link
Contributor

surapunoyousei commented Nov 2, 2022

Paxmod is an addon based on Webextensions unlike TabMixPlus which provides multi-row tabs.

I wanted Lepton to support this addon and have been working on improving compatibility with my own web browser.

First of all, Original and Photon don't work with this addon. It will be as follows.

Use Lepton
image

Use Proton
image

As a workaround, consider making the code below optional. This alone should solve the problem. Ultimately, I couldn't find a workaround due to the forcefulness in CSS.

I think you can turn it on by default. It should change quite a bit just by switching and working.

image


Floorp, the web browser I develop for, bypasses it with JS and CSS. I file this issue because I think it should benefit all users.

https://github.com/Floorp-Projects/Floorp/blob/205fe11909987ed235278eb0561ee40f12ddab11/floorp/browser/base/content/browser-command.js#L413 (The reason why there are two identical ones is that Original and Photon were separated.)
https://github.com/Floorp-Projects/Floorp/tree/ESR102/floorp/browser/themes/designs/lepton

image

Thank you very much for keeping up the great CSS.

@surapunoyousei surapunoyousei added the Issue::Enhancement New feature or request label Nov 2, 2022
@black7375
Copy link
Owner

It's a amazing project that it's possible only with Webextensions.
I'm going to start an investigation to support paxmod.

The cases used like waterfox, floorp and running cheese are quite important in the Open Source Software, so if possible, I think it is better to supports.

@surapunoyousei
Copy link
Contributor Author

Please let me know if there is anything I can do to help.

Should I submit this issue to Paxmod?

@black7375
Copy link
Owner

I'm waiting for an answer by submitting an issue. numirias/paxmod#100

@surapunoyousei
Copy link
Contributor Author

Finished writing the patch on the Paxmod side. I think everything will end with the response on the Lepton side.

@black7375
Copy link
Owner

It's very encouraging!!
It seems that webextension can replace AutoConfig(A.K.A userChromeJS fx-autoconfig and firefox-scripts) and Legacy Extensions in part.

@surapunoyousei
Copy link
Contributor Author

yes. However, legacy extensions are based on old technology, so Paxmod based on modern technology is fast and relatively secure.

I am happy to have contributed to this project. Now all that's left to do is wait until the PR is merged.

@black7375
Copy link
Owner

If possible, this project will also be switched to webextension. #502

@surapunoyousei
Copy link
Contributor Author

Will help. It's not that difficult.

But I think you'd be better off using a theme. Firefox still has experimental support for full theming possible with CSS.

Extensions are of course also possible.

@black7375
Copy link
Owner

The feature I want is that change the option value in real time, and there is an option related UI.
Perhaps JS is also necessary for sidebar and statusbar, so I was considering using autoconfig, but I just changed the roadmap. #2

@surapunoyousei
Copy link
Contributor Author

surapunoyousei commented May 5, 2023

Paxmod feels abandoned by owner. I plan to maintain it in the meantime.

@black7375
Copy link
Owner

Yeah, I don't know exactly why, but I also think maintainer's not active right now.

@surapunoyousei
Copy link
Contributor Author

surapunoyousei commented May 5, 2023

I am currently working on multilingualization of the extension. I will submit a PR when the maintainer returns. Patience until then.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants