Is interpolator property required?

[TedDriggs]

The interface for SharedElementTransitionGroup says it's required, but the examples on https://react-layout-transition.surge.sh/ it's not set and those work. Is the example incorrect?

[bkazi]

The website might be using an older version of the library, I might've forgotten to update it
The examples in the README should reflect the latest versions of the same examples.
I couldn't justify adding a default interpolator implementation to the classes hence it's required since it's used to drive the animations while also allowing for customisability as you can ship your own.
Any more comments on the API would be much appreciated!

[TedDriggs]

I couldn't justify adding a default interpolator implementation to the classes

Do you mind expanding on this a bit? It seems like it'd be useful to have the SETG "just work" without an interpolator, and I'm not following why you'd need a special 'default interpolator implementation'.

The sample code is also incorrect about how to import the interpolator; I had to use react-layout-transition/es/interpolators rather than using the react-layout-transition/interpolators path from the docs.

[bkazi]

I should really have dug deeper on the matter but at the time I wasn't too keen with the idea of having unused code and imports if another interpolator was used. Maybe dead code elimination would take care of it, I'm not sure. Might be worth me taking a look at some point

Aah I guess there's something wrong with how I thought build tools work. What bundler are you using and what version?

Sorry it's taking me time to get things done, it's peak exam season 🙈 but I hope to get back on it soon