Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env to defaultPodOptions #254

Open
halkeye opened this issue Jan 3, 2024 · 2 comments
Open

Add env to defaultPodOptions #254

halkeye opened this issue Jan 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@halkeye
Copy link
Contributor

halkeye commented Jan 3, 2024

Details

What steps did you take and what happened:

Trying to port immich-chart to the new v2 common (awesome library btw), but running into a snag trying to reproduce the global env on every pod.

What did you expect to happen:

Not sure, something

Anything else you would like to add:

Additional Information:

@halkeye halkeye added the bug Something isn't working label Jan 3, 2024
@bjw-s bjw-s added enhancement New feature or request and removed bug Something isn't working labels Jan 3, 2024
@onedr0p
Copy link
Contributor

onedr0p commented Apr 15, 2024

I wonder if it would be worth it to create a .Values.defaultContainersOptions instead and place it there, that way all containers in all the pods in all the controllers will have the values.

@halkeye
Copy link
Contributor Author

halkeye commented Apr 17, 2024

I don't know really. I decided to not try to make a public immich chart, so havn't really used the default options much. just a bunch of copy and pasting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants