remove a loop which makes the code even more performant

Author: bjarneo

dist/extract-domain.min.js

@@ -18,7 +18,7 @@ function getDomainFromUrl(url) {
 
     // Find offset of the domain
     while (len-- && ++i) {
-        if (domainInc && url[i] === '/') {
+        if (domainInc && (url[i] === '/' || url[i] === ':')) {
             break;
         }
 
@@ -31,6 +31,8 @@ function getDomainFromUrl(url) {
         offsetDomain = i;
     }
 
+    offsetPath = i;
+
     i = offsetDomain;
 
     // Find offset before domain name.
@@ -45,38 +47,11 @@ function getDomainFromUrl(url) {
         break;
     }
 
-    i = offsetDomain;
-
-    // Get the offset path
-    while (i++) {
-        if (i >= url.length) {
-            break;
-        }
-
-        // If we hit the port, set the offsetPath and break the loop
-        if (url[i] === ':') {
-            offsetPath = i;
-
-            break;
-        }
-
-        // Continue until we find the start of a path
-        if (url[i] !== '/') {
-            continue;
-        }
-
-        offsetPath = i;
-
-        break;
-    }
-
     // offsetStartSlice should always be larger than protocol
     if (offsetStartSlice < 6) {
         return '';
     }
 
-    // It has been a wild ride
-    // .. slice
     // Tried several approaches slicing a string. Can't get it any faster than this.
     return url.slice(offsetStartSlice, offsetPath);
 }

index.js

@@ -9,21 +9,17 @@ const urls = [
     'http://example.com:80/path/to/myfile.html?key1=value1&key2=value2#SomewhereInTheDocument',
     'http://www.so.many.sub.domains.example.com:80/path/to/myfile.html?key1=value1&key2=value2#SomewhereInTheDocument',
     'http://user:[email protected]:80/path/to/myfile.html?key1=value1&key2=value2#SomewhereInTheDocument',
-    'ftp://example.org/resource.txt'
+    'ftp://example.org/resource.txt',
+    'http://www.npmjs.com'
 ];
 
-const expected = [
-    'npmjs.com',
-    'example.com',
-    'npmjs.com',
-    'example.org'
-];
+const expected = [ 'npmjs.com', 'example.com', 'npmjs.com', 'example.org' ];
 
 describe('extract domain', () => {
     it('should extract given domain from string', () => {
-        assert.equal(extractDomain(urls[1]), expected[1]);
-
         assert.equal(extractDomain(urls[0]), expected[0]);
+        assert.equal(extractDomain(urls[1]), expected[1]);
+        assert.equal(extractDomain(urls[7]), expected[0]);
     });
 
     it('should extract given domain from an array of strings', () => {

index.test.js

@@ -1,6 +1,6 @@
 {
   "name": "extract-domain",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "description": "Extract domain from given string",
   "main": "dist/extract-domain.min.js",
   "author": "Bjarne Oeverli",