Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set team-appsec as codeowners of scan.y*ml workflows #101

Closed
wants to merge 1 commit into from

Conversation

joseph-flinn
Copy link

📔 Objective

Override the dept-devops CODEOWNERS policy for scan.y*ml files as the App Security team owns them.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@joseph-flinn joseph-flinn requested a review from a team as a code owner August 2, 2024 14:22
Copy link

github-actions bot commented Aug 2, 2024

Logo
Checkmarx One – Scan Summary & Detailsb8cd67f4-2c64-4ef2-9476-b17c9fc6a2e1

No New Or Fixed Issues Found

@joseph-flinn joseph-flinn enabled auto-merge (squash) August 2, 2024 14:26
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool if this could be centralized in the new workflow linter as more of a string search or regex, perhaps for "Checkmarx" or "Sonar".

@withinfocus
Copy link
Contributor

Not pursuing this. Teams will own scanning setup.

@withinfocus withinfocus closed this Sep 4, 2024
auto-merge was automatically disabled September 4, 2024 12:34

Pull request was closed

@withinfocus withinfocus deleted the assign-appsec-scan-ownership branch September 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants