Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to scanner configuration guide #100

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add link to scanner configuration guide #100

merged 1 commit into from
Jul 22, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Internal change.

📔 Objective

Adds a link where there's a bunch of info on how to configure the scanners.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@@ -10,6 +10,7 @@ on:
pull_request_target:
types: [opened, synchronize]

# TODO: see https://bitwarden.atlassian.net/l/cp/SLtTZJ90 for configuration tips
Copy link

@audreyality audreyality Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤍 Thank you! 💙

Copy link

Logo
Checkmarx One – Scan Summary & Detailscfa077db-5cb7-443a-80ca-57916088f0bf

No New Or Fixed Issues Found

@withinfocus withinfocus marked this pull request as ready for review July 22, 2024 15:28
@withinfocus withinfocus requested a review from a team as a code owner July 22, 2024 15:28
@withinfocus withinfocus merged commit 016dbeb into main Jul 22, 2024
4 checks passed
@withinfocus withinfocus deleted the tips branch July 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants