Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of snippet and just return a vanilla error #1140

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 14, 2024

we'll have to look into proper error handling anyways, so I'm just quickfixing this until then

🎟️ Tracking

📔 Objective

Snippets are not properly uploaded to npmjs. Bypassing the issue by not using snippets until we figure out error handling properly

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

we'll have to look into proper error handling anyways, so I'm just quickfixing this until then
@coroiu coroiu requested a review from dani-garcia October 14, 2024 14:53
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details24f416d5-0b9c-46ba-8cf8-f391866a9bc9

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 20 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /languages/java/example/Example.java: 46
MEDIUM Privacy_Violation /languages/java/example/Example.java: 44

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.17%. Comparing base (d094901) to head (c3016be).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/client.rs 0.00% 3 Missing ⚠️
crates/bitwarden-wasm-internal/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.02%     
==========================================
  Files         197      197              
  Lines       13584    13587       +3     
==========================================
  Hits         7904     7904              
- Misses       5680     5683       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu merged commit 8b44f55 into main Oct 14, 2024
96 of 99 checks passed
@coroiu coroiu deleted the ps/fix-error-snippet-not-available branch October 14, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants