You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hit Github API with a request for latest version of CLI as documented in Bitwarden docs.
We get redirected to the latest napi release instead of CLI release:
Redirect to latest release, which is currently a release of napi which does not contain CLI assets
Additional Context
GitHub releases are supposed to be used in a very specific way - with semantic version as the top level (release name) and various released components as its assets.
That way permalinks like /latest and /tag/xyz have the expected behavior.
At the moment SDK Repo is publishing multiple components (napi, python, cli) under the same release, so Github APIs are pretty much useless for integrations.
Perfect example of the problem is in Bitwarden's docs https://bitwarden.com/help/gitlab-integration/
If we take GitHub API request for /latest version of CLI from those docs, all of our integrations break as soon as napi or Python SDK is published because that's the latest and doesn't contain CLI.
One way to fix this is to separate napi, cli and python sdk in separate repos so they can all have individual release streams.
Another way is to version them together and always release them all as assets of each version.
Operating System
Windows, macOS, Linux
Operating System Version
No response
Build Version
1.0
Issue Tracking Info
I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
The text was updated successfully, but these errors were encountered:
Steps To Reproduce
Hit Github API with a request for latest version of CLI as documented in Bitwarden docs.
We get redirected to the latest napi release instead of CLI release:
Expected Result
Redirect to the latest CLI release
Actual Result
Redirect to latest release, which is currently a release of napi which does not contain CLI assets
Additional Context
GitHub releases are supposed to be used in a very specific way - with semantic version as the top level (release name) and various released components as its assets.
That way permalinks like /latest and /tag/xyz have the expected behavior.
At the moment SDK Repo is publishing multiple components (napi, python, cli) under the same release, so Github APIs are pretty much useless for integrations.
Perfect example of the problem is in Bitwarden's docs https://bitwarden.com/help/gitlab-integration/
If we take GitHub API request for /latest version of CLI from those docs, all of our integrations break as soon as napi or Python SDK is published because that's the latest and doesn't contain CLI.
One way to fix this is to separate napi, cli and python sdk in separate repos so they can all have individual release streams.
Another way is to version them together and always release them all as assets of each version.
Operating System
Windows, macOS, Linux
Operating System Version
No response
Build Version
1.0
Issue Tracking Info
The text was updated successfully, but these errors were encountered: