From ea85d75a27ede19ff5369337cdb0e34e9562dc94 Mon Sep 17 00:00:00 2001 From: Michal Checinski Date: Fri, 7 Jun 2024 17:09:02 +0200 Subject: [PATCH 1/7] BRE-101: Remove dept-devops from CODEOWNERS --- .github/CODEOWNERS | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 632eb5ff8..cac904571 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,6 +4,28 @@ # # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners +# BRE for release workflow changes +.github/workflows/publish-java.yml @bitwarden/dept-bre +.github/workflows/publish-python.yml @bitwarden/dept-bre +.github/workflows/release-go.yml @bitwarden/dept-bre +.github/workflows/publish-php.yml @bitwarden/dept-bre +.github/workflows/publish-ruby.yml @bitwarden/dept-bre +.github/workflows/release-cli.yml @bitwarden/dept-bre +.github/workflows/release-napi.yml @bitwarden/dept-bre +.github/workflows/release-wasm.yml @bitwarden/dept-bre +.github/workflows/publish-rust-crates.yml @bitwarden/dept-bre +.github/workflows/release-cpp.yml @bitwarden/dept-bre +.github/workflows/publish-dotnet.yml @bitwarden/dept-bre -# DevOps for Actions and other workflow changes. -.github/workflows @bitwarden/dept-devops +# BRE for release workflow changes +.github/workflows/publish-java.yml @bitwarden/dept-bre +.github/workflows/publish-python.yml @bitwarden/dept-bre +.github/workflows/release-go.yml @bitwarden/dept-bre +.github/workflows/publish-php.yml @bitwarden/dept-bre +.github/workflows/publish-ruby.yml @bitwarden/dept-bre +.github/workflows/release-cli.yml @bitwarden/dept-bre +.github/workflows/release-napi.yml @bitwarden/dept-bre +.github/workflows/release-wasm.yml @bitwarden/dept-bre +.github/workflows/publish-rust-crates.yml @bitwarden/dept-bre +.github/workflows/release-cpp.yml @bitwarden/dept-bre +.github/workflows/publish-dotnet.yml @bitwarden/dept-bre From b60a0a6649b441cd82eb7490564ff1991bc3ea73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Mon, 10 Jun 2024 15:36:18 +0200 Subject: [PATCH 2/7] Fix --- .github/CODEOWNERS | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cac904571..ef4561047 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -16,16 +16,3 @@ .github/workflows/publish-rust-crates.yml @bitwarden/dept-bre .github/workflows/release-cpp.yml @bitwarden/dept-bre .github/workflows/publish-dotnet.yml @bitwarden/dept-bre - -# BRE for release workflow changes -.github/workflows/publish-java.yml @bitwarden/dept-bre -.github/workflows/publish-python.yml @bitwarden/dept-bre -.github/workflows/release-go.yml @bitwarden/dept-bre -.github/workflows/publish-php.yml @bitwarden/dept-bre -.github/workflows/publish-ruby.yml @bitwarden/dept-bre -.github/workflows/release-cli.yml @bitwarden/dept-bre -.github/workflows/release-napi.yml @bitwarden/dept-bre -.github/workflows/release-wasm.yml @bitwarden/dept-bre -.github/workflows/publish-rust-crates.yml @bitwarden/dept-bre -.github/workflows/release-cpp.yml @bitwarden/dept-bre -.github/workflows/publish-dotnet.yml @bitwarden/dept-bre From 986a2ae63de18890b7843c3835f391f080bb1a81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Tue, 15 Oct 2024 14:13:40 +0200 Subject: [PATCH 3/7] Change codeowners --- .github/CODEOWNERS | 72 +++++++++++++++++++++++++++++++++++++++------- 1 file changed, 62 insertions(+), 10 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index faf5a2eb4..da4859f52 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,18 +4,64 @@ # # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners -# BRE for release workflow changes -.github/workflows/publish-java.yml @bitwarden/dept-bre -.github/workflows/publish-python.yml @bitwarden/dept-bre +# BRE for publish workflow changes +.github/workflows/publish-*.yml @bitwarden/dept-bre + +# Shared workflows ownership + +## BRE & SM teams shared ownership +.github/workflows/build-cli-docker.yml @bitwarden/dept-bre +.github/workflows/build-cli.yml @bitwarden/dept-bre +.github/workflows/build-cpp.yml @bitwarden/dept-bre +.github/workflows/build-dotnet.yml @bitwarden/dept-bre +.github/workflows/build-go.yml @bitwarden/dept-bre +.github/workflows/build-java.yml @bitwarden/dept-bre +.github/workflows/build-napi.yml @bitwarden/dept-bre +.github/workflows/build-python-wheels.yml @bitwarden/dept-bre +.github/workflows/build-ruby.yml @bitwarden/dept-bre +.github/workflows/build-rust-crates.yml @bitwarden/dept-bre +.github/workflows/release-bws.yml @bitwarden/dept-bre +.github/workflows/release-cpp.yml @bitwarden/dept-bre +.github/workflows/release-dotnet.yml @bitwarden/dept-bre .github/workflows/release-go.yml @bitwarden/dept-bre -.github/workflows/publish-php.yml @bitwarden/dept-bre -.github/workflows/publish-ruby.yml @bitwarden/dept-bre -.github/workflows/release-cli.yml @bitwarden/dept-bre +.github/workflows/release-java.yml @bitwarden/dept-bre .github/workflows/release-napi.yml @bitwarden/dept-bre -.github/workflows/release-wasm.yml @bitwarden/dept-bre -.github/workflows/publish-rust-crates.yml @bitwarden/dept-bre -.github/workflows/release-cpp.yml @bitwarden/dept-bre -.github/workflows/publish-dotnet.yml @bitwarden/dept-bre +.github/workflows/release-python.yml @bitwarden/dept-bre +.github/workflows/release-ruby.yml @bitwarden/dept-bre + +.github/workflows/build-cli-docker.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-cli.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-cpp.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-dotnet.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-go.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-java.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-napi.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-python-wheels.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-ruby.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-rust-crates.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-bws.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-cpp.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-dotnet.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-go.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-java.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-napi.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-python.yml @bitwarden/team-secrets-manager-dev +.github/workflows/release-ruby.yml @bitwarden/team-secrets-manager-dev + +## Multiple owners +.github/workflows/build-android.yml +.github/workflows/build-rust-crates.yml +.github/workflows/build-rust-cross-platform.yml +.github/workflows/build-swift.yml +.github/workflows/build-wasm-internal.yml +.github/workflows/build-wasm.yml +.github/workflows/release-rust-crates.yml +.github/workflows/release-swift.yml +.github/workflows/release-wasm.yml + +.github/workflows/version-bump.yml + + # Secrets Manager team crates/bitwarden-sm @bitwarden/team-secrets-manager-dev @@ -25,3 +71,9 @@ crates/bws @bitwarden/team-secrets-manager-dev crates/bws/Cargo.toml crates/bws/scripts/install.ps1 crates/bws/scripts/install.sh + +## Docker files have shared ownership ## +**/Dockerfile +**/*.Dockerfile +**/.dockerignore +**/entrypoint.sh From 23090e50699d806e84547b903eaa34a3ecc395ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Tue, 15 Oct 2024 16:58:07 +0200 Subject: [PATCH 4/7] Update .github/CODEOWNERS Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index da4859f52..006de6140 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -10,7 +10,7 @@ # Shared workflows ownership ## BRE & SM teams shared ownership -.github/workflows/build-cli-docker.yml @bitwarden/dept-bre +.github/workflows/build-cli-docker.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev .github/workflows/build-cli.yml @bitwarden/dept-bre .github/workflows/build-cpp.yml @bitwarden/dept-bre .github/workflows/build-dotnet.yml @bitwarden/dept-bre From 03c042e9a837dc5a65ef043074156ccefe3ac61c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Tue, 15 Oct 2024 16:59:28 +0200 Subject: [PATCH 5/7] Fix --- .github/CODEOWNERS | 53 +++++++++++++++------------------------------- 1 file changed, 17 insertions(+), 36 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 006de6140..a017ddea8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -11,42 +11,23 @@ ## BRE & SM teams shared ownership .github/workflows/build-cli-docker.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev -.github/workflows/build-cli.yml @bitwarden/dept-bre -.github/workflows/build-cpp.yml @bitwarden/dept-bre -.github/workflows/build-dotnet.yml @bitwarden/dept-bre -.github/workflows/build-go.yml @bitwarden/dept-bre -.github/workflows/build-java.yml @bitwarden/dept-bre -.github/workflows/build-napi.yml @bitwarden/dept-bre -.github/workflows/build-python-wheels.yml @bitwarden/dept-bre -.github/workflows/build-ruby.yml @bitwarden/dept-bre -.github/workflows/build-rust-crates.yml @bitwarden/dept-bre -.github/workflows/release-bws.yml @bitwarden/dept-bre -.github/workflows/release-cpp.yml @bitwarden/dept-bre -.github/workflows/release-dotnet.yml @bitwarden/dept-bre -.github/workflows/release-go.yml @bitwarden/dept-bre -.github/workflows/release-java.yml @bitwarden/dept-bre -.github/workflows/release-napi.yml @bitwarden/dept-bre -.github/workflows/release-python.yml @bitwarden/dept-bre -.github/workflows/release-ruby.yml @bitwarden/dept-bre - -.github/workflows/build-cli-docker.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-cli.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-cpp.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-dotnet.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-go.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-java.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-napi.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-python-wheels.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-ruby.yml @bitwarden/team-secrets-manager-dev -.github/workflows/build-rust-crates.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-bws.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-cpp.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-dotnet.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-go.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-java.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-napi.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-python.yml @bitwarden/team-secrets-manager-dev -.github/workflows/release-ruby.yml @bitwarden/team-secrets-manager-dev +.github/workflows/build-cli.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-rust-crates.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-bws.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-python.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev ## Multiple owners .github/workflows/build-android.yml From fed0b69eea43e72add10ff395606bbb42ad087d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Thu, 17 Oct 2024 11:35:37 +0200 Subject: [PATCH 6/7] Update .github/CODEOWNERS Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> --- .github/CODEOWNERS | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a017ddea8..02d416700 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -39,7 +39,6 @@ .github/workflows/release-rust-crates.yml .github/workflows/release-swift.yml .github/workflows/release-wasm.yml - .github/workflows/version-bump.yml From 93e03315529fd076df6c27cd773b8653adfac870 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Thu, 17 Oct 2024 11:37:13 +0200 Subject: [PATCH 7/7] Fix --- .github/CODEOWNERS | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 02d416700..2698af85c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -19,7 +19,6 @@ .github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev .github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev .github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev -.github/workflows/build-rust-crates.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev .github/workflows/release-bws.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev .github/workflows/release-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev .github/workflows/release-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev