Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FirstName & LastName fields for registration. #69

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jul 2, 2024

Description

  • Implements the First Name & Last Name fields added to the Users table.
  • Upon extending the functionality, I discovered I implemented adding additional credentials incorrectly using the registration endpoint. We now properly use the POST /users/{userId}/credentials endpoint to add additional passkeys.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner July 2, 2024 09:44
@jonashendrickx jonashendrickx merged commit 38b4357 into main Jul 2, 2024
4 checks passed
@jonashendrickx jonashendrickx deleted the use-firstname-and-lastname-in-users-table branch July 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants